This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Create Dockerfile and trainer.sh #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trainer.sh takes in github url, oauth token as argument and clones a private repo Dockerfile is based on Python 3.7 base image, and calls the trainer script
|
Addresses part of #5 |
coder46
reviewed
Oct 5, 2020
docker/trainer.sh
Outdated
| r) git_url=${OPTARG};; | ||
| t) oauth_token=${OPTARG};; | ||
| p) project_name=${OPTARG}; | ||
| esac |
There was a problem hiding this comment.
Question - are these options being read as environment variables ? for eg git_url should be read from $GIT_URL
added 2 commits
October 5, 2020 11:24
Ubuntu has better compatibility with data scientists
coder46
reviewed
Oct 6, 2020
docker/trainer.sh
Outdated
|
|
||
| cd $project_name | ||
| pip install -r requirements.txt | ||
| python train.py |
There was a problem hiding this comment.
Lets now take the model file to run as a relative path via environment variable $MODEL_PATH
docker/Dockerfile
Outdated
| @@ -0,0 +1,6 @@ | |||
| FROM python:3.7-buster | |||
There was a problem hiding this comment.
can you use ubuntu as base image ?
There was a problem hiding this comment.
Also any specific reason for using 3.7-buster ?
There was a problem hiding this comment.
Hey I changed the base image to Ubuntu 20.04
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trainer.sh takes in github url, oauth token as argument and clones a private repo
Dockerfile is based on Python 3.7 base image, and calls the trainer script