This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trainer.sh takes in github url, oauth token as argument and clones a private repo Dockerfile is based on Python 3.7 base image, and calls the trainer script
Ubuntu has better compatibility with data scientists
- Modify CIL options - Add local_execution.sh that builds the docker image for local training - Change the name of trainer.sh to executor.sh
coder46
reviewed
Oct 6, 2020
coder46
reviewed
Oct 6, 2020
coder46
reviewed
Oct 6, 2020
First, check if local repo match with remote master branch. Then, in docker, clone the remote repo and run the specified job
coder46
suggested changes
Oct 8, 2020
@tsa87 Also please add tests for the |
tsa87
commented
Oct 8, 2020
docker/local_execution.sh
Outdated
Comment on lines
1
to
7
|
||
DIR="$( dirname "${BASH_SOURCE[0]}" )" | ||
LOG_NAME=$(date +'%Y_%m_%d_%H_%M_%S') | ||
|
||
cd $DIR | ||
#TODO Bug fix building hydra image | ||
docker build -t hydra_image . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addresses #11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature #5 and #6