Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Publish to PyPI upon Tag #121

Merged
merged 7 commits into from
Apr 5, 2024
Merged

[CI] Publish to PyPI upon Tag #121

merged 7 commits into from
Apr 5, 2024

Conversation

benjaminye
Copy link
Contributor

This PR introduces CI pipeline for PyPI. Addresses #114, #106.

What does this PR do?

  • Establish git tags as single source of truth for package releases and versioning

  • Workflow is triggered when

    • using Github web UI to tag and publish a new release
      image
    • using Github CLI to publish a new release
      • e.g. gh release create --repo seanh/gha-python-packaging-demo --generate-notes 0.0.1
  • Dynamic versioning and version convention (Semver) enforcement via poetry plugin

    • Version specified by tag will be replacing values found within pyproject.toml as well as in any __init__.py files (i.e. where we do __version__='0.0.0').

Requirement

@truskovskiyk
Copy link
Contributor

@benjaminye we don't have the right to add secrets, so this is going to be blocked for now

@benjaminye
Copy link
Contributor Author

@benjaminye we don't have the right to add secrets, so this is going to be blocked for now

@truskovskiyk, I can add repo-scoped secrets for this repo that I created: https://github.com/georgian-io/cohere-rerank-eval.

Seems like you need to be the owner of the repo to be able to do this. @RohitSaha please confirm if this guide works for you: https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#creating-secrets-for-a-repository

@benjaminye
Copy link
Contributor Author

@truskovskiyk

Forked the repo and tested the pypi publish workflow on testPyPI. It's working as desired.

image

@benjaminye benjaminye merged commit b281456 into main Apr 5, 2024
3 checks passed
@benjaminye benjaminye deleted the github-ci-pypi branch April 5, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants