Integrate main qa #131
Merged
Integrate main qa #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@viveksingh-ctrl |
benjaminye
reviewed
Apr 8, 2024
benjaminye
reviewed
Apr 11, 2024
llmtune/cli/toolkit.py
Outdated
Comment on lines
2
to
4
| import os | ||
| from os import listdir | ||
| from os.path import exists, join |
There was a problem hiding this comment.
Suggested change
| import os | |
| from os import listdir | |
| from os.path import exists, join |
There was a problem hiding this comment.
We are moving all the directory operations to pathlib
benjaminye
reviewed
Apr 11, 2024
llmtune/cli/toolkit.py
Outdated
Comment on lines
93
to
95
| qa_path = dir_helper.save_paths.qa | ||
| if not exists(qa_path) or not listdir(qa_path): | ||
| # Instantiate unit test classes |
There was a problem hiding this comment.
Suggested change
| qa_path = dir_helper.save_paths.qa | |
| if not exists(qa_path) or not listdir(qa_path): | |
| # Instantiate unit test classes | |
| qa_file_path = dir_helper.save_paths.qa_file | |
| if not qa_file_path.exists(): | |
| # Instantiate unit test classes |
benjaminye
reviewed
Apr 11, 2024
llmtune/cli/toolkit.py
Outdated
| qa_path = dir_helper.save_paths.qa | ||
| if not exists(qa_path) or not listdir(qa_path): | ||
| # Instantiate unit test classes | ||
| llm_tests = config.get("qa", {}).get("llm_tests", []) |
There was a problem hiding this comment.
Suggested change
| llm_tests = config.get("qa", {}).get("llm_tests", []) | |
| llm_tests = config.qa.llm_tests |
benjaminye
reviewed
Apr 11, 2024
llmtune/cli/toolkit.py
Outdated
| llm_tests = config.get("qa", {}).get("llm_tests", []) | ||
| tests = QaTestRegistry.create_tests_from_list(llm_tests) | ||
| test_suite = LLMTestSuite.from_csv(results_file_path, tests) | ||
| test_suite.save_test_results(os.path.join(qa_path, "unit_test_results.csv")) |
There was a problem hiding this comment.
Suggested change
| test_suite.save_test_results(os.path.join(qa_path, "unit_test_results.csv")) | |
| test_suite.save_test_results(qa_file_path) |
benjaminye
approved these changes
Apr 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.