Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused ORC code #95

Open
thinrope opened this issue Sep 23, 2020 · 1 comment
Open

remove unused ORC code #95

thinrope opened this issue Sep 23, 2020 · 1 comment

Comments

@thinrope
Copy link

I have been looking around and there are is quite a pile of ORC code that per your comment is not used:

https://github.com/georgmartius/vid.stab/blob/master/CMakeLists.txt#L32

### ORC is not used in any active code at the moment  ###
# I tried it with 0.4.14
#  0.4.10 did not work (not all opcode implemented)
# find_package(Orc)

I am talking about the snippet above, as well as src/orc and test/orc_bug and some references in the makefiles.
@georgmartius
Copy link
Owner

True, it was not useful and will not become useful again. If you feel like creating a merge request -- always welcome ;-)

thinrope added a commit to thinrope/vid.stab that referenced this issue Feb 11, 2024
@thinrope
Obliterating most any reference to ORC
05d2903 
This should clean the code and fix issue georgmartius#95

Bug:georgmartius#95
Signed-off-by:Kalin KOZHUHAROV <kalin@thinrope.net>
@thinrope thinrope mentioned this issue Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thinrope @georgmartius