Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check availability of SSE* instructions on target platform #114

Merged
merged 2 commits into from
May 30, 2022

Conversation

Karry
Copy link
Contributor

@Karry Karry commented Jan 28, 2022

Checking sse instructions on build host by reading /proc/cpuinfo
is not usable for crosscompilation.

Fix for #109

Checking sse instructions on build host by reading /proc/cpuinfo
is not usable for crosscompilation.
@georgmartius
Copy link
Owner

Hi Karry,
thanks for fixing this. On which platforms have you tried it so far?

@Karry
Copy link
Contributor Author

Karry commented May 30, 2022

I tried it on armv7l (directly on hardware) and aarch64 crosscompilation. And of course on x86_64.

@georgmartius
Copy link
Owner

Wonderful.

@georgmartius
Copy link
Owner

I was running the checks and they failed. Can you also see them? If I understand correctly, the cmakefile in the test folder also need adaptation, right?

@Karry
Copy link
Contributor Author

Karry commented May 30, 2022

It is good to have CI builds ;-) It is just necessary to replace PROJECT_SOURCE_DIR by CMAKE_CURRENT_LIST_DIR

@georgmartius georgmartius merged commit 6ba034b into georgmartius:master May 30, 2022
@Karry Karry deleted the sse branch May 30, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants