Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProxyClassRebuildCommand is not symfony/* 7.0 compatible #2312

Closed
sfroemkenjw opened this issue Jan 16, 2024 · 2 comments · Fixed by #2313
Closed

ProxyClassRebuildCommand is not symfony/* 7.0 compatible #2312

sfroemkenjw opened this issue Jan 16, 2024 · 2 comments · Fixed by #2313

Comments

@sfroemkenjw
Copy link
Contributor

Bug Report

Current Behavior
I got following error:

Fatal error: Declaration of GeorgRinger\News\Command\ProxyClassRebuildCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /var/www/html/vendor/georgringer/news/Classes/Command/ProxyClassRebuildCommand.php on line 26

Expected behavior/output
No error message

Environment

  • TYPO3 version(s): [12.4.10]
  • news version: [e.g. 11.3.0]
  • Is your TYPO3 installation set up with Composer (Composer Mode): [yes]

Possible Solution

  • Do not support symfony/* packages 7.0
  • Make execute compatible to new symfony version
@oliverklee
Copy link
Sponsor Contributor

In general, I'd recommend using explicit dependencies (e.g., on symfony/console) in the composer.json when the extension relies on components/packages instead of depending on transitive dependencies (which caused this problem).

@andreaskienast
Copy link
Contributor

In general, I'd recommend using explicit dependencies (e.g., on symfony/console) [...].

This, and tools like Rector would've identified this beforehand. The offending change is known since Symfony 5.x (no offense, tho).

oliverklee added a commit to oliverklee/news that referenced this issue Jan 16, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Related to georgringer#2312
oliverklee added a commit to oliverklee/news that referenced this issue Jan 16, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Also reorder the dependencies to follow best practices.

Related to georgringer#2312
oliverklee added a commit to oliverklee/news that referenced this issue Jan 16, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Also reorder the dependencies to follow best practices.

Related to georgringer#2312
oliverklee added a commit to oliverklee/news that referenced this issue Jan 16, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Also reorder the dependencies to follow best practices.

Related to georgringer#2312
oliverklee added a commit to oliverklee/news that referenced this issue Jan 17, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Also reorder the dependencies to follow best practices.

Related to georgringer#2312
oliverklee added a commit to oliverklee/news that referenced this issue Jan 18, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Also reorder the dependencies to follow best practices.

Related to georgringer#2312
oliverklee added a commit to oliverklee/news that referenced this issue Jan 21, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Also reorder the dependencies to follow best practices.

Related to georgringer#2312
oliverklee added a commit to oliverklee/news that referenced this issue Jan 22, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Also reorder the dependencies to follow best practices.

Related to georgringer#2312
oliverklee added a commit to oliverklee/news that referenced this issue Jan 26, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Also reorder the dependencies to follow best practices.

Related to georgringer#2312
oliverklee added a commit to oliverklee/news that referenced this issue Jan 26, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Related to georgringer#2312
georgringer pushed a commit that referenced this issue Jan 26, 2024
Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Related to #2312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants