Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows tests #341

Merged
merged 8 commits into from
Nov 21, 2022
Merged

Fix windows tests #341

merged 8 commits into from
Nov 21, 2022

Conversation

mwm126
Copy link
Contributor

@mwm126 mwm126 commented Nov 20, 2022

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Copy link
Contributor

@metasim metasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not actually able to test on a Windows computer, so my review is only source-level. 😄

src/raster/tests.rs Outdated Show resolved Hide resolved
src/vector/feature.rs Outdated Show resolved Hide resolved
src/vector/vector_tests/mod.rs Outdated Show resolved Hide resolved
@mwm126
Copy link
Contributor Author

mwm126 commented Nov 21, 2022

Implemented fixes. I can't test on Windows at the moment, but I can test tomorrow.
Hopefully PR 218 can then be merged!

@pka
Copy link
Member

pka commented Nov 21, 2022

#218 disables all broken tests, so it did run fine back then.

@mwm126
Copy link
Contributor Author

mwm126 commented Nov 21, 2022

The issues with /tmp/ on Windows are resolved, but I was also getting an error:

---- vector::vector_tests::tests::test_write_features stdout ----
thread 'vector::vector_tests::tests::test_write_features' panicked at 'called `Result::unwrap()`
on an `Err` value: Os { code: 32, kind: Uncategorized,
message: "The process cannot access the file because it is being used by another process." }',
 src\vector\vector_tests\mod.rs:793:53
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

My solution was to put the open ds: Dataset in it's own scope so that it's closed before being removed (to tidy up after the test), which results in all tests passing on Windows (for me).

@metasim
Copy link
Contributor

metasim commented Nov 21, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 21, 2022

@bors bors bot merged commit a9d2ba1 into georust:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants