Refactoring vector module for better maintainability and extensibility.
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
approved these changes
Feb 13, 2023
Not a nit... I've already renamed those 5 times. 🙈 |
metasim
force-pushed
the
feature/vector-refactor
branch
from
0f60449
to
b91d20f
Compare
jdroenner
approved these changes
Feb 15, 2023
Changes include: * Grouping methods of similar purpose into separate files * Putting associated tests in the same file as the implementation * Adding or expanding documentation on existing methods * Normalizing documentation patterns and format.
metasim
force-pushed
the
feature/vector-refactor
branch
from
b91d20f
to
0ab98e0
Compare
|
@lnicola @jdroenner I'm going to merge this, and then in a separate PR implement |
Anyway, we can probably merge this. bors d+ |
|
✌️ metasim can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Actually, maybe there's no breaking changes? bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Refactoring to improve maintainability of vector module.
Changes include:
Intent was to not have any breaking changes.