Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass GDT_Unknown for vector layers #393

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented May 5, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Closes #392

@lnicola
Copy link
Member Author

lnicola commented May 5, 2023

r? @callmeahab

@lnicola lnicola changed the title Pass GDT_Unknown for vector layers Pass GDT_Unknown for vector layers May 5, 2023
Copy link

@callmeahab callmeahab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing to OpenFileGDB works

@lnicola
Copy link
Member Author

lnicola commented May 7, 2023

r? @jdroenner

Copy link
Contributor

@metasim metasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the generics simplified away.

@lnicola
Copy link
Member Author

lnicola commented May 8, 2023

bors r=metasim

Good night, sweet prince.

bors bot added a commit that referenced this pull request May 8, 2023
393: Pass `GDT_Unknown` for vector layers r=metasim a=lnicola

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md).
- [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---

Closes #392

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
@lnicola
Copy link
Member Author

lnicola commented May 8, 2023

bors r-

@bors
Copy link
Contributor

bors bot commented May 8, 2023

Canceled.

@lnicola
Copy link
Member Author

lnicola commented May 8, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented May 8, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit d738722 into georust:master May 8, 2023
@lnicola lnicola deleted the vector-layer-type branch May 8, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating a gdb file with OpenFileGDB driver
3 participants