Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up spatial_ref module into feature-focused submodules. #395

Merged
merged 3 commits into from
May 11, 2023

Conversation

metasim
Copy link
Contributor

@metasim metasim commented May 9, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Also added small bits of documentation and fixed clippy warnings.

Aside: I originally started this refactor because I'm about to expose the GCP API and erroneously thought it would be a part of the spatial_ref API. But now I see it's only raster-related. Therefore, this is basically some simple house-keeping...

src/dataset.rs Outdated Show resolved Hide resolved
@metasim metasim force-pushed the feature/srs-refactor branch 2 times, most recently from 0cb95fa to ccf5971 Compare May 9, 2023 21:53
@lnicola
Copy link
Member

lnicola commented May 10, 2023

I didn't look at the other changes, but I don't think that function should be unsafe. I filed #360 for that, which.. you've already seen? 😄

@metasim
Copy link
Contributor Author

metasim commented May 10, 2023

@lnicola

I didn't look at the other changes, but I don't think that function should be unsafe. I filed #360 for that, which.. you've already seen? 😄

Ah! I misread your ticket!... and thought you were saying the opposite 🤦

I defer to your experience here. I'll remove it here, and we can create a new PR to handle the other cases.... or find an all around better way.

CHANGES.md Outdated
@@ -81,6 +81,10 @@

- <https://github.com/georust/gdal/pull/370>

- Split `spatial_ref` module into more feature-specific submodules. (Public API is unchanged.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if users will care about this :-).

Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these refactoring and documentation PRs, I think they're great!

@metasim
Copy link
Contributor Author

metasim commented May 11, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented May 11, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f3f20ef into georust:master May 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants