GHA Workflow for running tests under a more strict memory checking environment #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metasim
force-pushed
the
feature/asan
branch
2 times, most recently
from
8566786
to
135e211
Compare
metasim
changed the title
metasim
force-pushed
the
feature/asan
branch
4 times, most recently
from
ea261d1
to
05018e5
Compare
metasim
changed the title
lnicola
reviewed
May 17, 2023
lnicola
reviewed
May 17, 2023
lnicola
reviewed
May 17, 2023
lnicola
reviewed
May 17, 2023
metasim
force-pushed
the
feature/asan
branch
5 times, most recently
from
b41d884
to
340801e
Compare
lnicola
reviewed
May 18, 2023
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
lnicola
reviewed
May 18, 2023
lnicola
approved these changes
May 18, 2023
|
bors +r |
|
Did you mean "r+"? |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
@lnicola Thank you for your thorough review and support. I got what I was hoping for 😄: 
|
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.If I've configured this correctly, once
sanitizer.ymlis on themasterbranch, we should be able to manually initiate running of this workflow on PRs via theworkflow_dispatchtrigger.Notes:
cargo-carefulcargo-carefulenablesAddressSanitizer, whose options can be configured viaASAN_OPTIONS