fix polygon centroid for flat polygon #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the polygon is flat (area = 0), it is considered as a linestring without this for a flat polygon eg: A ----> B -----> C ^----------------| the centroid was `Some(NaN, NaN)`
|
Good catch. Thank you! |
|
bors r=urschrei |
bors bot
added a commit
that referenced
this pull request
Apr 18, 2018
203: fix polygon centroid for flat polygon r=urschrei a=antoine-de if the polygon is flat (area = 0), it is considered as a linestring for the centroid computation. without this for a flat polygon eg: A ----> B -----> C ^-------------------| the centroid was `Some(NaN, NaN)` without this, the test `empty_interior_polygon_test` was also causing a `panic!` because of the unwrap in the centroid method. Co-authored-by: Antoine D <antoine.desbordes@gmail.com>
Build succeeded |
|
great, thanks! when do you think this will be released? |
|
@antoine-de released to crates.io as |
|
thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the polygon is flat (area = 0), it is considered as a linestring for the centroid computation.
without this for a flat polygon eg:
the centroid was
Some(NaN, NaN)without this, the test
empty_interior_polygon_testwas also causing apanic!because of the unwrap in the centroid method.