Geometrycollection ergonomics #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2019 13:18
…y geometries it contains
frewsxcv
reviewed
Feb 16, 2019
geo-types/src/geometry_collection.rs
Outdated
| @@ -11,12 +11,33 @@ pub struct GeometryCollection<T>(pub Vec<Geometry<T>>) | |||
| where | |||
| T: CoordinateType; | |||
|
|
|||
| impl<T: CoordinateType> GeometryCollection<T> { | |||
| /// Return an empty GeometryCollection | |||
| pub fn empty() -> GeometryCollection<T> { | |||
There was a problem hiding this comment.
Suggested change
| pub fn empty() -> GeometryCollection<T> { | |
| pub fn new() -> GeometryCollection<T> { |
thoughts on calling this new? this matches other empty collection constructors in rust, e.g. Vec::new, HashMap::new
There was a problem hiding this comment.
or implement Default ? even if I'm not sure it makes sense for a GeometryCollection
frewsxcv
approved these changes
Feb 17, 2019
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just some minor ergonomic improvements