Adding Rect constructor to address issue #359: #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Update internal Rect struct literals to use constructors. 3. Use of the Rect struct literals in unit tests are left alone.
|
🔒 Permission denied Existing reviewers: click here to make Chopinsky a reviewer |
frewsxcv
reviewed
May 11, 2019
| @@ -12,6 +12,35 @@ where | |||
| } | |||
|
|
|||
| impl<T: CoordinateType> Rect<T> { | |||
| /// Creates a new rectangle. | |||
| /// | |||
| /// # Examples | |||
There was a problem hiding this comment.
Would you mind adding a # Panics section above this documenting how this function can panic? Thanks!
There was a problem hiding this comment.
Just updated the doc to mention the panic conditions.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 26, 2019
360: Adding Rect constructor to address issue #359: r=frewsxcv a=Chopinsky To address the issue #359 of lacking a Rect geo-type constructor that can perform coordinates validations, I've made the following changes: 1. Add a `new` constructor to the Rect geo-type. 2. Update all internal use of the Rect struct literals to the new constructor. However, existing use of the Rect struct literals in unit tests are left alone. Co-authored-by: Jacob Zuo <chopinsky@live.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the issue #359 of lacking a Rect geo-type constructor that can perform coordinates validations, I've made the following changes:
newconstructor to the Rect geo-type.However, existing use of the Rect struct literals in unit tests are left alone.