Add conditional Eq impl for Coordinate, maybe other types? #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
approved these changes
Mar 24, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 29, 2020
431: Add conditional Eq impl for Coordinate, maybe other types? r=frewsxcv a=nick-parker I haven't written tests or anything for this but I wanted to throw the PR in to get discussion started. Many geometry algorithms eg this [optimal algorithm for computing mesh cross-sections and reconstructing the polygons](https://www.researchgate.net/publication/309619647_An_Optimal_Algorithm_for_3D_Triangle_Mesh_Slicing) use Hashtables or similar to keep track of coordinates. This impl lets me put geo Coordinate structs in the Hashtable instead of dealing with a separate struct just for this step. I haven't put much thought into whether similar one-liner Eq impl's should be added for Linestring, Polygon, etc but I don't really see why not. The use cases are rarer but probably still exist. 432: Add Triangle and Rect to Geometry. r=frewsxcv a=frewsxcv Fixes #390 Extracted from https://github.com/georust/geo/pull/421/files Co-authored-by: Nick Parker <nmp67@cornell.edu> Co-authored-by: Corey Farwell <coreyf@rwell.org>
|
This PR was included in a batch that timed out, it will be automatically retried |
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Apr 2, 2020
435: derive Eq for other core geo types r=frewsxcv a=michaelkirk Adds `Eq` conformance to other core geo types, building off of #431 > Seems reasonable to me! Yeah +1 to adding the same impl for all the other core geo types Rather than spelling out the impl, I've taken advantage of how `derive` already bounds the generated impl for us. See rust-lang/rust#21237 for more details I wrote a few doc-tests while developing, but I reverted them in fc33f9f since they're pretty verbose, and seem superfluous since they're only asserting rust language semantics rather than anything substantial in this lib. I can un-revert them if you'd prefer. Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't written tests or anything for this but I wanted to throw the PR in to get discussion started.
Many geometry algorithms eg this optimal algorithm for computing mesh cross-sections and reconstructing the polygons use Hashtables or similar to keep track of coordinates. This impl lets me put geo Coordinate structs in the Hashtable instead of dealing with a separate struct just for this step.
I haven't put much thought into whether similar one-liner Eq impl's should be added for Linestring, Polygon, etc but I don't really see why not. The use cases are rarer but probably still exist.