Add more implementations for Contains algorithm. #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
approved these changes
May 8, 2020
| } | ||
|
|
||
| /// Calculate the position of a `Coordinate` relative to a `LineString` | ||
| pub fn coord_pos_relative_to_line_string<T>( |
There was a problem hiding this comment.
Assuming this was a straight move and rename from algorithm::contains::get_position
There was a problem hiding this comment.
yep, just moved, changed the param from point to coord, and renamed
| where | ||
| T: Float, | ||
| { | ||
| fn contains(&self, p: &Point<T>) -> bool { |
There was a problem hiding this comment.
This example I contrived fails:
use geo::algorithm::contains::Contains;
use geo::{LineString, Point};
let line_string = LineString::from(vec![(0., 0.), (3., 3.)]);
let point_on_line = Point::new(1., 1.);
assert!(line_string.contains(&point_on_line)); // <- 💥 currently failsI don't think this was a change in behavior with this PR, but at least one point of comparison, postgis, agrees that we should change it so that my example passes:
psql> SELECT ST_Contains(
ST_MakeLine(ST_MakePoint(0,0), ST_MakePoint(3,3)),
ST_MakePoint(1,1)
);
st_contains
-------------
t
LMK what you think. If you agree that we should change it and want to punt on the implementation, I can take a look!
There was a problem hiding this comment.
ooo good find. i'm going to merge this as-is, and open a separate issue for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl Contains<Coordinate> for Pointimpl Contains<Coordinate> for MultiPointimpl Contains<Point> for MultiPointimpl Contains<Coordinate> for Lineimpl Contains<Coordinate> for LineStringimpl Contains<Coordinate> for MultiLineStringimpl Contains<Point> for MultiLineStringimpl Contains<Coordinate> for Polygonimpl Contains<Coordinate> for MultiPolygonimpl Contains<Coordinate> for Rectimpl Contains<Coordinate> for Triangleimpl Contains<Coordinate> for Geometryimpl Contains<Point> for Geometryimpl Contains<Coordinate> for GeometryCollectionimpl Contains<Point> for GeometryCollection