Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Default for Coordinate and Point #616

Merged
merged 3 commits into from
Feb 5, 2021
Merged

Implement Default for Coordinate and Point #616

merged 3 commits into from
Feb 5, 2021

Conversation

sbland
Copy link
Contributor

@sbland sbland commented Feb 2, 2021

  • [/ ] I agree to follow the project's code of conduct.
  • [/ ] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

PR for issue #612

michaelkirk
michaelkirk approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I'm going to leave it open for a week in case others want to weigh in.

Thanks!

@michaelkirk
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Feb 4, 2021
@bors
Try #616:
56c7830
frewsxcv
frewsxcv approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changelog tweak, but looks good to me!

geo-types/CHANGES.md Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors bot commented Feb 4, 2021

try

Build succeeded:

@frewsxcv
Copy link
Member

frewsxcv commented Feb 5, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 5, 2021

Build succeeded:

@bors bors bot merged commit 6a74467 into georust:master Feb 5, 2021
@frewsxcv frewsxcv mentioned this pull request Feb 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkirk michaelkirk michaelkirk approved these changes

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbland @michaelkirk @frewsxcv