New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CI testing matrix #673
Conversation
This reduces the CI time from 26 to 6.5 minutes. |
Should we also disable testing the |
I wanted to, but was worried we wouldn't test new features. But yeah, let's try it. |
Updated. |
Lgtm! Let's see if anyone with more knowledge of the proj integration has some comments. Ping @michaelkirk @urschrei . |
I'm trying to think of ways in which not testing the network functionality could cause an issue for geo, but so far I'm coming up blank: all the functionality enabled by the feature is in the proj crate, releases of which are gated on passing tests (which include testing network functionality). The feature builds our bundled version of proj, adding a build dependency on libtiff, as well as depending on 'reqwest'. |
- run: cargo install cargo-all-features | ||
- run: cargo build-all-features | ||
- run: cargo test-all-features | ||
- run: cargo check --all-targets --no-default-features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, can you add a comment as to why we're not doing --all-features
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added a comment.
Looks like we're down to ~7 minutes now, with the |
bors r+ Let's do it! |
Build succeeded: |
/cc @frewsxcv re: #671 (comment) I just wanted to make sure that you saw this PR was merged. In hindsight, I should have tagged you earlier, since I know you are especially interested in our testing strategy. |
CHANGES.md
if knowledge of this change could be valuable to users.Closes #672