Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test_std_geodesic_geodsolve29 failure #25

Closed
stonylohr opened this issue Jan 23, 2021 · 1 comment
Closed

fix test_std_geodesic_geodsolve29 failure #25

stonylohr opened this issue Jan 23, 2021 · 1 comment

Comments

@stonylohr
Copy link
Contributor

This standard Karney unit test currently fails. Fix geodesic to make it work.

Tests longitude unrolling with inverse calculation. It also happens to use a large-ish flattening (0.1), though the test description doesn't highlight that.
@stonylohr
Copy link
Contributor Author

I have a fix ready for this as well. I'll submit the PR once pull 37 (for #36) is resolved.

The issue is right there in my trailing remark -- this test is supposed to use WGS84, and instead I used the high-flattening geodesic from geodesic28 due to a copy-paste error.

I'll move on to #20 (test_arcdirect) next.

stonylohr added a commit to stonylohr/geographiclib-rs that referenced this issue Jan 30, 2021
@stonylohr
fix georust#25: geodsolve29
7476861 
Copy-paste bug in the test itself
bors bot added a commit that referenced this issue Jan 30, 2021
@bors @stonylohr
Merge #38
d4162ad 
38: fix #25: geodsolve29. r=michaelkirk a=stonylohr

Test was using wrong ellipsoid, due to copy-paste error.

- [ ] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md).
- [ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---



Co-authored-by: Stony <stony.lohr@gmail.com>
@bors bors bot closed this as completed in b3daf4d Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stonylohr