static build

[gauteh]

Add static feature flag as discussed in #20. Builds and tests fine. libgeos version is 3.9.1.

To build make sure that submodules are updated and inited: git submodule update --init.

• Remember to add static flag to geos (add static feature flag geos#94)

❯ ldd libgeos_sys.so
        linux-vdso.so.1 (0x00007fff3c773000)
        libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fc515d37000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fc515b1f000)
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fc515917000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fc5156f8000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fc51535a000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fc515156000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fc514d65000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fc516470000)

Motivation

• Allows dependent crates to be built into python packages supporting the manywheels spec (making them easier to distribute)
• Allows easier compilation of geos-sys without needing libgeos installed on the system
• Allows easier distribution of binaries / libs without needing same version of libgeos
• Can use a specific / and same version of libgeos

[gauteh]

Some licencing stuff missing. Currently pinned to geos 3.9.1.

[gauteh]

I updated the PR with some motivation (top entry).

[gauteh]

There is something wrong with this still, I haven't been able to correctly link geos.

[gauteh]

Figured it out. Had forgotten to link to geos C++ library too.

[gauteh]

geos tests pass with this one as well as tests using a library dependent on geos again. It is an open question which version of geos to ship.

[gauteh]

Hi. This has been tested extensively for a good while now. This change enables the use og this crate in manylinux python packages.

[pka]

I'm very excited about the possibility to use GEOS in Rust without external dependency! Code looks fine for me. Only question is about embedding the C source code with a git submodule. Does a shallow clone still work, resp. is cloning the submodule only necessary for static linking?

@GuillaumeGomez: Would be great having that merged!

[gauteh]

Shallow should work when not using static. You won't have to think about shallow/deep when installing from crates. man. 29. nov. 2021, 09:01 skrev Pirmin Kalberer ***@***.***>:

…

I'm very excited about the possibility to use GEOS in Rust without external dependency! Code looks fine for me. Only question is about embedding the C source code with a git submodule. Does a shallow clone still work, resp. is cloning the submodule only necessary for static linking? @GuillaumeGomez <https://github.com/GuillaumeGomez>: Would be great having that merged! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#21 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAN3665U3JWQTAILK55K4LUOMXORANCNFSM5DMJZNXA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[gauteh]

Hi, do you have any chance at looking at this? Been using for a long time.

[GuillaumeGomez]

Sorry, I was busy when you opened this PR and then completely forgot about it. Sorry about that. Thanks for this improvement! I'll merge as is to not take any more time and then add a mention of this feature in the README.

[gauteh]

Thanks a lot! This should make georust/geos#99 work as well (perhaps after a release).

[GuillaumeGomez]

I'm just curious about something: isn't it possible to have this static link without creating a new crate?

[gauteh]

Hm, maybe, I think you'd have to (optionally) build the -src crate in build.rs and link it in there.

[GuillaumeGomez]

That'd make things much easier overall. Want to give it a try?

[gauteh]

I just tried a little, and it would probably involve calling cargo from build.rs. I see that other libraries usually distribute a -src package:

• https://crates.io/crates/netcdf-src/0.2.0
• https://docs.rs/openssl-src/111.18.0+1.1.1n/openssl_src/
• https://docs.rs/hdf5-src/0.8.1/hdf5_src/

I think that it would be a bit fragile and messy, so I think the best solution is a -src crate, even though that is not super-great. It does open for depending on different -src versions, which would help the end-user (I have sometimes, temporarily, needed to depend on a specific -src version of openssl to get the build to work).

[GuillaumeGomez]

Then it's fine. Let's keep thins as is. Just one last thing: what happens if the submodule isn't present when you build in the repository? By default, when building a dependency, I guess it won't be present so it's very likely that it'll never work, right?

[gauteh]

Without static you won't notice. With static it won't work and you'll have to init them before building. Note that cargo checks out with submodules when installing as deps or binaries.

[GuillaumeGomez]

Does it when you simply use it as a dependency?

[gauteh]

If you use it as a simple dependency (e.g. https://github.com/gauteh/roaring-landmask/blob/main/Cargo.toml#L21) then you don't have to think about it. It will be checked out as necessary by cargo. So both static and without will work without knowing about the git repo structure. I am not sure if the submodule is mirrored to crates.io as well, but it works for all other packages I've used (netcdf, hdf, openssl). Pretty sure I modelled this setup after openssl.

[GuillaumeGomez]

Then it's fine. I'll publish both crates so you can update the geos PR.

[gauteh]

Great! Thanks!

…

On Mon, Mar 21, 2022 at 11:20 AM Guillaume Gomez ***@***.***> wrote: Then it's fine. I'll publish both crates so you can update the geos PR. — Reply to this email directly, view it on GitHub <#21 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAN366LS376O7VK2ANNBDDVBBEPFANCNFSM5DMJZNXA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>