Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

crates publishing team #80

Closed
2 tasks
michaelkirk opened this issue Oct 28, 2020 · 11 comments
Closed
2 tasks

crates publishing team #80

michaelkirk opened this issue Oct 28, 2020 · 11 comments
Assignees

Comments

@michaelkirk
Copy link
Member

michaelkirk commented Oct 28, 2020

馃憢 Hi @GuillaumeGomez and @antoine-de, you two are the only "user-owners" of the geos crate on crates.io, so only you can edit that crate's owners on crates.io.

Following up on georust/meta#21, I created a new geos-publishers team for publishing to crates.io with you as maintainer.

Could you please update the crate owners? Specifically:


cd geos

# 馃挜 remove large publishing team
cargo owner --remove github:georust:core

# 馃攼 add small publishing team
cargo owner --add github:georust:geos-publishers

# make sure everything looks good 馃憖 
cargo owner --list

cd geos

# 馃挜 geos-sys didn't have the georust/core team as a team-owner
# 馃攼 add small publishing team (assuming you'd prefer to share a publishing team between geos and geos-sys crates)
cargo owner --add github:georust:geos-publishers

# 馃毃 @GuillaumeGomez: note that you are the *sole* user-owner of the geos-sys crate. 
# Consider adding another user-owner so that someone can still update the crate owners if you become inaccessible. Maybe @antoine-de?
cargo owner --add antoine-de

# make sure everything looks good 馃憖 
cargo owner --list

If there's anyone else you'd like to be able to publish the crates, feel free to add them to your publishing team, or as a user-owner. Consider that user-owners, as opposed to owners-via-team, can themselves edit the crate's owners, which could be desirable, or not, depending.

Once you switch the publishing team, no one else will be able to publish until either they are added to the new publishing team or added as a user-owner.

Let me know if you have any questions, or you can review georust/meta#21.

@GuillaumeGomez
Copy link
Member

I'll when there will be another maintainer showing up. :)

@frewsxcv
Copy link
Member

@GuillaumeGomez can you clarify what you mean?

@GuillaumeGomez
Copy link
Member

Sure: what I meant is simply that I don't think handing the maintenance to a team is a good idea. However, if someone contributes to geos crates, I have no issue to add them as well (that's what I did for gtk-rs). Currently we are two already, so the chances of both of us disappearing at the same time is quite low.

@frewsxcv
Copy link
Member

frewsxcv commented Oct 29, 2020

@GuillaumeGomez there seems to be a misunderstanding of this GitHub Issue. the goal of this is to limit, not expand, who can publish the geos crate. currently everyone in the georust github organization can publish it. when you have some time, please read georust/meta#21.

@GuillaumeGomez
Copy link
Member

Oh! My bad. Then I'll do shortly. Sorry for the misunderstanding...

@GuillaumeGomez
Copy link
Member

I get the following error:

$ cargo owner --remove 'github:georust:core'
    Updating crates.io index
       Owner removing ["github:georust:core"] from crate geos
error: failed to remove owners from crate geos

Caused by:
  api errors (status 200 OK): could not find the github team georust/core

$ cargo owner --list
    Updating crates.io index
GuillaumeGomez (Guillaume Gomez)
antoine-de (Antoine D)
github:georust:core (Core)

@frewsxcv
Copy link
Member

weird. @GuillaumeGomez can you try making the changes in the UI here? https://crates.io/crates/geos/owners

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Oct 29, 2020

And done! Closing it then. (and thanks for the link!)

@frewsxcv
Copy link
Member

looks like georust/core is still an owner: https://crates.io/crates/geos/owners

i wonder if this is a crates.io bug?

@GuillaumeGomez
Copy link
Member

Ah you're right! I got the message saying it was removed though... Opening an issue for them then.

michaelkirk added a commit to georust/meta that referenced this issue Nov 12, 2020
With one exception (technical difficulties w/ crates.io at georust/geos#80) this has been completed for all our crates, so no need to clutter up the docs with steps which no longer apply to anyone.

Since this is a minor change that doesn't change the spirit of the guideline, I'm not planning on trying to solicit a bunch of feedback. Happy to hear any though - I'll leave it open for a week.
@GuillaumeGomez
Copy link
Member

The team was removed successfully from the owners list. Closing then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants