Tessellator was broken for years! Revert-fixing. #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
fix-tesssellation
branch
from
d205c38
to
6400dfc
Compare
* Due to a typo in the cfg flag, tessellator was never built properly (we can even remove it as it is clearly not being used by anyone). * This is a known issues in the rust compiler 10554 * I reverted Lyon to 0.16.2 and it worked fine. * Add nightly build step to verify that the cfg is OK Do we want to keep this and spend the effort to upgrade to the latest Lyon crate, or is this a useless feature and should be removed?
nyurik
force-pushed
the
fix-tesssellation
branch
from
6400dfc
to
bf3d64d
Compare
pka
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--check-cfgintegration rust-lang/cargo#10554checkstep to make sure this won't happen againDo we want to keep this and spend the effort to upgrade to the latest Lyon crate, or is this a useless feature and should be removed?