Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace geo with geo-types #20

Merged
merged 3 commits into from
Sep 15, 2018
Merged

Replace geo with geo-types #20

merged 3 commits into from
Sep 15, 2018

Conversation

felgru
Copy link
Member

@felgru felgru commented Sep 14, 2018

Closes #13.

There were some minor changes necessary as in geo 0.10 the Bbox type
has been renamed to Rect which now holds two Coordinates of the lower
left and upper right corner.
Since we only use the types that have been factored out into the
geo-types crate, there is no need to include the whole geo crate
anymore.

We do, however, still need the geo crate as a dev-dependency, as the
some of its algorithms are used by our tests.

Closes georust#13
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@frewsxcv
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Sep 15, 2018
20: Replace geo with geo-types r=frewsxcv a=felgru

Closes #13.

Co-authored-by: Felix Gruber <felgru@gmx.de>
@bors
Copy link
Contributor

bors bot commented Sep 15, 2018

Build succeeded

@bors bors bot merged commit 595bfd3 into georust:master Sep 15, 2018
@felgru felgru deleted the use-geo-types branch September 16, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants