implement writing of GPX files #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new function write(gpx, writer) can now be used to write a given GPX object to a Write object.
Those tests read the sample GPX files from test/fixtures/ and compare the resulting Gpx objects to ones obtained from writing and re-reading those Gpx objects.
We now write the `age` attribute of a `Waypoint` object as <ageofgpsdata> element instead of <ageof**d**gpsdata> to be consistent to our parser used by the `read` function. This is not consistent with the GPX 1.1 (and 1.0) schema, where the element is named <ageofdgpsdata>.
frewsxcv
approved these changes
Sep 23, 2018
There was a problem hiding this comment.
wow, thanks for adding this functionality! to increase ownership of this project, i just added you to the github organization. you should be able to merge and publish a new version to crates.io. if you're not interested, let me know and i can do that for you 🙋♂️
|
Thank you for your invitation! I'll merge this pull request and try to release a new version on crates.io. If I have any questions, I'll let you know (this is the first time I release anything on crates.io, so I'm first going to read the crates.io documentation to make sure that I don't do anything wrong). |
|
@felgru thanks for putting this together! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
gpx::writefunction that writes a givenGpxobject into an object implementing theWritetrait. This can be used to write GPX data to a .gpx file.Depending on the version set in the
Gpxobject it writes GPX 1.1 or 1.0 data.Closes #19.