allow empty fields: "desc", "cmt", "description", "keywords", "src" #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue with a
.gpx
file, where the"cmt"
and the"desc"
fields for the waypoints were empty. It looks to me that is not a problem to have an empty comment or description. Looking at the spec, it just states that those fields must be strings (https://www.topografix.com/GPX/1/1/#type_wptType) , but there is no specification about if the have to be at least of length > 0.My approach to fix it has been to modify the
string::consume
function, that accepts and additional bool parameterallow_empty
. Another way would be to create a different function (consume_opt
for example), that calls the originalconsume
and checks the error. The problem with this approach is that I would need to check for the type of error returned from thestring::consume
function, and only if is the"no content inside string"
one, return the empty string.