Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waypoint name can be an empty string #71

Merged
merged 3 commits into from
May 27, 2022
Merged

Waypoint name can be an empty string #71

merged 3 commits into from
May 27, 2022

Conversation

cedeber
Copy link
Contributor

@cedeber cedeber commented May 21, 2022

Fixes #70

@urschrei
Copy link
Member

I've added a test and updated the changelog since we're now fixing two instances of divergence from the spec (see #72), which I think warrants a bugfix release, and I don't want to wait.

@urschrei
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request May 27, 2022
@bors @cedeber @urschrei
Merge #71
da97ca9 
71: Waypoint name can be an empty string r=urschrei a=cedeber

Fixes #70




Co-authored-by: Cédric Eberhardt <hello+code@cedeber.fr>
Co-authored-by: Stephan Hügel <shugel@tcd.ie>
@bors
Copy link
Contributor

bors bot commented May 27, 2022

Build failed:

@urschrei
Copy link
Member

I've opened #73 to address the CI failure

@urschrei
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented May 27, 2022

Build succeeded:

@bors bors bot merged commit 73d8dcc into georust:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Waypoint name can be an empty string
3 participants
@cedeber @urschrei @lnicola