Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize deps: Drop error_chain and move assert_approximate_eq to dev-deps #91

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

w-flo
Copy link
Contributor

@w-flo w-flo commented Jun 26, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Well, first of all, thanks again for the gpx crate! I've noticed the latest version parses gpx files that use some extensions without throwing an error, and I can access the time without going through a parse/format cycle, so it's even better now compared to last time I participated in this repo.

I'm not sure how valuable a changelog entry for this would be for users, and English is not my native language. So I haven't added one. Let me know if I should, or feel free to add it yourself if you want :-)

I've noticed these deps do not appear to be needed. The error_chain dependency seems especially "wasteful" because it brings in a bunch of transitive dependencies. Commit messages:


Move `assert_approx_eq` crate to dev-dependencies

The crate is used in two test cases and appears not to be needed
otherwise.

Remove error_chain remnants

The code no longer depends on error_chain since #58, but the dependency
was still listed in Cargo.toml. There still was one commented-out "use"
directive.

Drops the number of build steps from 69 to 48, and helps with
compilation time a bit.

The code no longer depends on error_chain since georust#58, but the dependency
was still listed in Cargo.toml. There still was one commented-out "use"
directive.

Drops the number of build steps from 69 to 48, and helps with
compilation time a bit.
The crate is used in two test cases and appears not to be needed
otherwise.
@michaelkirk
Copy link
Member

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 26, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 032cf32 into georust:master Jun 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants