fix: allow cumulative innerBoundaryIs tags on a polygon #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! I'll take a closer look, but at first glance it looks good. Don't worry about the clippy error, that's not coming from you changes so we can handle that separately |
pjsier
reviewed
Jan 2, 2024
src/reader.rs
Outdated
| @@ -353,7 +353,10 @@ where | |||
| } | |||
| outer = outer_ring.remove(0); | |||
| } | |||
| b"innerBoundaryIs" => inner = self.read_boundary(b"innerBoundaryIs")?, | |||
| b"innerBoundaryIs" => { | |||
| let mut boundary = self.read_boundary(b"innerBoundaryIs")?; | |||
There was a problem hiding this comment.
Do we need the intermediate variable or would this be fine?
inner.append(&mut self.read_boundary(b"innerBoundaryIs")?);There was a problem hiding this comment.
Great point, thanks! Just made the change.
pjsier
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Google KML docs, a Polygon is allowed to have "0 or more inner boundaries".
Source
In the current parser, the LinearRings within an
innerBoundaryIstags are assigned to theinnerfield of a parsed Polygon. However, if multipleinnerBoundaryIstags are present, only the last is currently assigned to theinnerfield of the Polygon. The proposed change appends output frominnerBoundaryIstags so that consecutive tags don't overwrite each other.I created a small reproduction of this issue in a separate repo:
.txtfiles show the output difference between the current library and the changes in this branch.Aside:
This is my first open source contribution. If I'm missing anything, please let me know! I appreciate everyone's work on this library and am grateful for the opportunity to give back.