Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endian support #35

Merged
merged 5 commits into from
Oct 26, 2019
Merged

Add endian support #35

merged 5 commits into from
Oct 26, 2019

Conversation

lwandrebeck
Copy link
Contributor

No description provided.

@lwandrebeck lwandrebeck mentioned this pull request Oct 25, 2019
Closed
@codecov-io
Copy link

codecov-io commented Oct 25, 2019 •
edited

Codecov Report

Merging #35 into master will decrease coverage by <.01%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   91.91%   91.91%   -0.01%     
==========================================
  Files           8        8              
  Lines        1595     1632      +37     
==========================================
+ Hits         1466     1500      +34     
- Misses        129      132       +3
Impacted Files Coverage Δ
tests/lib.rs 98.86% <100%> (+0.02%) ⬆️
src/variable.rs 87.82% <86.36%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 806b0ed...b01cc1d. Read the comment docs.

magnusuMET
magnusuMET requested changes Oct 25, 2019
View reviewed changes
Copy link
Member

@magnusuMET magnusuMET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jus some small nitpicks

src/variable.rs Outdated Show resolved Hide resolved
src/variable.rs Outdated Show resolved Hide resolved
@magnusuMET
Copy link
Member

fixes #28

@magnusuMET magnusuMET merged commit 193bcd6 into georust:master Oct 26, 2019
@magnusuMET
Copy link
Member

Thanks!

@magnusuMET magnusuMET mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnusuMET magnusuMET magnusuMET approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lwandrebeck @codecov-io @magnusuMET