Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ndarray 0.11 #7

Merged
merged 2 commits into from
Dec 29, 2017
Merged

Use ndarray 0.11 #7

merged 2 commits into from
Dec 29, 2017

Conversation

bluss
Copy link
Contributor

@bluss bluss commented Dec 29, 2017

This is just a simple version upgrade of ndarray.

Hi, I'm currently writing something (of experimental quality) that looks a bit like DataArray / xarray for Rust, using netcdf and ndarray. Thanks for writing this crate, it's one of those stepping stones that makes it so much easier for me to get started.

This is just a simpler way to write the same thing.
@evomassiny
Copy link
Collaborator

Thank you :)

@evomassiny evomassiny merged commit f858f33 into georust:master Dec 29, 2017
@bluss bluss deleted the ndarray-0.11 branch December 29, 2017 22:46
@bluss
Copy link
Contributor Author

bluss commented Dec 30, 2017

I guess, note that ndarray is a public dep so a version upgrade there should normally count as breaking.

I've also noticed this library is GPL3 which I think is a good license, but it will make it complicated to build upon. It doesn't shrink the value of using the library for prototyping though..

@mhiley mhiley mentioned this pull request Jan 2, 2018
@mhiley
Copy link
Collaborator

mhiley commented Jan 2, 2018

@bluss I don't have any problem with changing the license. I created issue #9 to do so and assigned it to myself, but feel free to go ahead and send a PR to do that if you get to it before I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants