Updates to bindings and docs #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- specify proj.4, now that proj.5 has been released - Update dependencies - Replace use of tuples (not layout-safe for FFI) with `c_void` - Add rudimentary inline docs - Add example from tests to README
|
(preliminary steps toward addressing some issues in georust/geo#32) |
frewsxcv
approved these changes
Mar 11, 2018
README.md
Outdated
| Rust bindings for [proj](https://github.com/OSGeo/proj.4) | ||
| Rust bindings for [proj.4](https://github.com/OSGeo/proj.4) | ||
|
|
||
| # Example |
README.md
Outdated
| "+proj=sterea +lat_0=46 +lon_0=25 +k=0.99975 +x_0=500000 +y_0=500000 +ellps=krass +units=m +no_defs" | ||
| ).unwrap(); | ||
| let rp = stereo70.project(&wgs84, Point::new(500000., 500000.)); | ||
| # New Point coords are (0.436332, 0.802851) |
There was a problem hiding this comment.
alternatively, you could do an assert_eq!
README.md
Outdated
| extern crate geo; | ||
| use geo::types::Point; | ||
|
|
||
| # reproject coordinates from Stereo70 with custom params into WGS84 lon and lat coordinates |
There was a problem hiding this comment.
comments in rust start with // 😅
|
looks like i need to give publish permissions, one sec |
|
done |
|
<3 I think I've set them up correctly for georust core for proj-sys |
|
yep, looks good! also gonna close #1 |
bors bot
added a commit
that referenced
this pull request
Mar 12, 2018
6: Move to proj-sys and proj.4 v5 r=frewsxcv a=urschrei With the surprising release (after about 23 years) of proj.4 v5, and my blowing-the-cobwebs-off PR from yesterday (#5), I thought I'd publish a [`proj-sys`](https://crates.io/crates/proj-sys) crate (generated using `bindgen`), and use it as the basis for this. Currently, the API contains a very breaking change, because proj.4 performs operations differently now: it distinguishes between _projection_ (conversions from geodetic to projected coordinates) and _conversion_ (conversions between projected coordinate systems, usually within the same datum / reference frame). The latter uses a concept proj.4 calls the [`pipeline`](http://proj4.org/operations/pipeline.html), which allows for multi-step operations to achieve almost any kind of conversion, as opposed to the old system, which only allowed the specification of `from` and `to` projections. This change is mirrored in the rust-proj API: for simple (inverse) projection from/to geodetic coordinates, there's `project`, and for conversions and transformations there's `convert`. I'm not 100% sold on the API, because it feels a bit less flexible than the old one: you could specify different destination projections, and re-use the `Proj` struct. Using the new API, you have to specify everything up front, but you have a great deal more flexibility in terms of what you can do with it (see the `conversion` example). The conversion function also returns a `Result` now, and errors are implemented using `Failure`. <s>Anyway, this is currently WIP until I figure out how to detect errors using the new API.</s>
urschrei
added a commit
to urschrei/rust-proj
that referenced
this pull request
Sep 28, 2020
Bump PROJ.4 to v5.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proj.4API version, now thatproj.4v5.0.0 has been releasedc_void