Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Update GMAO submodule versions in GCHP 13.1 #55

Closed
lizziel opened this issue Oct 22, 2020 · 3 comments
Closed

[FEATURE REQUEST] Update GMAO submodule versions in GCHP 13.1 #55

lizziel opened this issue Oct 22, 2020 · 3 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@lizziel
Copy link
Contributor

lizziel commented Oct 22, 2020

4/8/2021 Update: Table now reflects versions to be included in 13.1
5/14 Update: Advection libraries will also be updated in 13.1

GCHP 13.0 includes upgrades to all GMAO libraries relative to what is used in GCHP 12. However, most of these libraries have already had several additional version releases. We should upgrade again for GCHP 13.1.

Below is a table of each GCHPctm submodule that is a fork from GMAO, either GEOS-ESM or Goddard-Fortran-Ecosystem. Let me know if you think I missed one of the repos used in GCHPctm. The target versions are the latest available, but if there is a newer version at the time this work is done then we take that for the merge. Only take tagged versions that are on the upstream main branch.

Repository versions in 13.0 and targets for 13.1

Repository Version in 13.0.0 Target for 13.1 Notes
FMS geos/orphan/v1.0.3 geos/2019.01.02+noaff.6 Our version is an orphan branch so special handling is needed for the upgrade.
MAPL v2.2.7 v2.6.3 Working on bug fix for v2.6.4.
GMAO_Shared v1.1.6 v1.3.8 We do not use most of the content in this repository. Update the skip list in CMakeLists.txt as needed.
fvdycore geos/v1.1.2 v1.1.6 Beware this is a submodule within a submodule.
FVdycoreCubed_GridComp v1.1.3 v1.2.12 An internal benchmark is essential when updating this library due to potential changes in offline advection which is not thoroughly tested at GMAO.
ESMA_cmake v3.0.6 v3.0.6 No version change in 13.1.
ecbuild geos/v1.0.5 geos/v1.0.6 If there is a new version to upgrade to, beware this is a submodule within a submodule.
gFTL-shared v1.0.7 v1.2.0 We are using a fork of this repo but perhaps do not need to.
gFTL v1.2.5 v1.3.1 We are not using a fork of this repo.
pFlogger v1.4.2 v1.5.0 We do not yet harness the full power of this library, but should in the future.
yaFyaml v0.4.0 v0.5.0 We should be able to use this to read the GEOS-Chem species database, but it has not yet been tried.
pFUnit v4.1.9 v4.2.0 We do not currently build this library, but it is included in GCHPctm for potential future use.

Related to this, another goal I have is to use Goddard-Fortran-Ecosystem/GFE which Tom put together at my request to bundle the Goddard-Fortran-Ecosystem repos together. We generally do not change these libraries so could avoid using forks potentially. I have permissions to make branches on the upstream as needed. GFE could sit as a submodule within GCHPctm/src, replacing gFTL-shared, pFlogger, pFUnit, and yaFyaml in that directory, which would be much cleaner.

@lizziel lizziel added the feature New feature or request label Oct 22, 2020
@lizziel lizziel added this to the 13.1.0 milestone Oct 22, 2020
lizziel added a commit that referenced this issue Oct 23, 2020
Submodule src/GCHP_GridComp/HEMCO_GridComp/HEMCO db95516..a225cd3:
  > Merge pull request #55 from geoschem/feature/sphinx-docs

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel
Copy link
Contributor Author

lizziel commented Nov 5, 2020

GMAO gave an update that the estimated version of MAPL with functional monthly diagnostics will be 2.3.5.

It is important to note that the monthly diagnostics update is expected to include an optional feature to output time-averaged History diagnostics with filename and time of the start of the time-averaging period. Currently all History diagnostics that are time-averaged use the center of the time-averaging period instead.

After this update, for consistency, we will want to output all History diagnostics with start time rather than center time so that the convention matches between monthly and non-monthly GCHP time-averaged output, and so it is consistent with the convention of GEOS-Chem Classic. We need to make sure, however, that the new time-averaged file includes metadata that enables the user to deduce the file is time-averaged and what the time-averaging window is. This may require some back-and-forth with GMAO.

Also note that this change will have implications for GCPy which will need updating prior to benchmarking. It will make comparison with previous versions tricky in the benchmark scripts.

@yantosca yantosca added the never stale Never label this issue as stale label Jan 13, 2021
@msulprizio msulprizio removed the never stale Never label this issue as stale label Mar 3, 2021
@lizziel
Copy link
Contributor Author

lizziel commented Mar 25, 2021

The MAPL update for this will be PR geoschem/MAPL#6 which brings MAPL up to v2.6.4. Validation is still in progress.

@lizziel
Copy link
Contributor Author

lizziel commented May 14, 2021

See also separate issue for updating advection libraries: #92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants