Added support for driving GCHP with native GEOS metfields.

[LiamBindle]

The main change in this PR is the handling for METEOROLOGY_VERTICAL_INDEX_IS_TOP_DOWN in GCHPctmEnv.

Parent PR (feature/native-metfields)

• [SUBMODULE UPDATES] Add support for reading native GEOS meteorological files #165

[yantosca]

The integration tests are failing due to an error in MAPL_GridCompMod.F90. There is a variable called reverse_time which is an integer but is treated as a logical. Intel allows this but Gfortran chokes. See: https://dev.azure.com/geoschem/GCHP/_build/results?buildId=1469&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=9c939e41-62c2-5605-5e05-fc3554afc9f5&l=3446

[msulprizio]

The integration tests are failing due to an error in MAPL_GridCompMod.F90. There is a variable called reverse_time which is an integer but is treated as a logical.

The integration tests are failing because of this PR geoschem/MAPL#12, which is already in dev. Once that issue in dev is fixed, this PR should pass the Quick Build tests.

[LiamBindle]

I reran the CI pipeline and it passes now.

This PR is ready for review.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

[lizziel]

I may be missing something, but I'm not seeing why it is necessary to allocate the local arrays to store the vertically flipped imports. Aren't the humidities only used here:

GCHP/src/GCHP_GridComp/GCHPctmEnv_GridComp/GCHPctmEnv_GridCompMod.F90

Lines 677 to 697 in efbba11

	! Stack up dry delta-P to get surface dry pressure
	Do L=1,LM
	! Pre-advection
	PEdge_Bot = AP(L ) + BP(L ) * PS0(I,J)
	PEdge_Top = AP(L+1) + BP(L+1) * PS0(I,J)
	PSDry0 = PSDry0 + (PEdge_Bot - PEdge_Top) &
	* (1.d0 - SPHU0(I,J,L))
	! Post-advection
	PEdge_Bot = AP(L ) + BP(L ) * PS1(I,J)
	PEdge_Top = AP(L+1) + BP(L+1) * PS1(I,J)
	PSDry1 = PSDry1 + (PEdge_Bot - PEdge_Top) &
	* (1.d0 - SPHU1(I,J,L))
	End Do
	! Work back up from the surface to get dry level edges
	! Do wet pressure at the same time - why not
	Do L=1,LM+1
	DryPLE0r8(I,J,L-1) = 100.d0*(AP(L)+(BP(L)*PSDry0 ))
	DryPLE1r8(I,J,L-1) = 100.d0*(AP(L)+(BP(L)*PSDry1 ))
	PLE0r8 (I,J,L-1) = 100.d0*(AP(L)+(BP(L)*PS0(I,J)))
	PLE1r8 (I,J,L-1) = 100.d0*(AP(L)+(BP(L)*PS1(I,J)))
	End Do

If yes, can't the L index be swapped with the vertically flipped equivalent?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

[lizziel]

@LiamBindle, just checking on if you saw my review for this from early November.

[yantosca]

I created a new branch in the GCHP superproject repo that points to the corresponding updates in both GEOS-Chem and HEMCO submodules. Integration tests and benchmarks will follow.