Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCHP_WRAPPER cpp definition #396

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Mar 18, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR adds new pre-processor definition GCHP_WRAPPER to GCHP. It is needed for use in Cloud-J and can be used for other submodules in the future. The name matches the analogous pre-processor switch called GCCLASSIC_WRAPPER that is in GEOS-Chem Classic.

This update is a required for use with Cloud-J PR geoschem/Cloud-J#2 and GEOS-Chem PR geoschem/geos-chem#2154.

Expected changes

This is a no diff update.

Reference(s)

None

Related Github PRs

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel added the category: Feature Request New feature or request label Mar 18, 2024
@lizziel lizziel added this to the 14.3.1 milestone Mar 18, 2024
@lizziel lizziel requested a review from yantosca March 18, 2024 19:54
@lizziel lizziel changed the base branch from main to dev/no-diff-to-benchmark March 18, 2024 19:54
@lizziel lizziel changed the title Feature/gchp wrapper cpp def Add GCHP_WRAPPER cpp definition Mar 18, 2024
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizziel! I'll merge it in and rerun integration tests

@yantosca yantosca added topic: Build Related to makefiles or the build sequence no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations labels Mar 18, 2024
@yantosca
Copy link
Contributor

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #6ca8b1f Add new pre-processor definition GCHP_WRAPPER for use in submodules
GEOS-Chem #9c5803931 Merge PR #2154 (Updates for GEOS-Chem 14.3 in CESM)
HEMCO     #22de25e Merge PR #263 (Restrict volcano clim prints to root thread)

Number of execution tests: 6

Submitted as SLURM job: 23864207
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also all GCHP integration tests were zero-diff w/r/t 14.3.0.

@yantosca yantosca merged commit e80c2dd into dev/no-diff-to-benchmark Mar 18, 2024
@yantosca yantosca deleted the feature/gchp_wrapper_cpp_def branch March 18, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Build Related to makefiles or the build sequence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants