Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PULL REQUEST] Bug fix in megan extension #140

Merged
merged 3 commits into from
Apr 8, 2022
Merged

[PULL REQUEST] Bug fix in megan extension #140

merged 3 commits into from
Apr 8, 2022

Commits on Apr 4, 2022

  1. Set biogenic annual emissions factors to zero before computing them 

    Previously the AEF arrays were not reset to zero before the computation
summing over plant types. Therefore the AEF values increased every
timestep, which was a bug.

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
    @lizziel
    lizziel committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    193b4f0 View commit details
    Browse the repository at this point in the history

  2. Initialize HEMCO arrays for megan restart fields using single precision 

    These arrays are defined as single precision but the initialization
value was previously hemco (flexible) precision.

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
    @lizziel
    lizziel committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    ed7eace View commit details
    Browse the repository at this point in the history

  3. Remove redundant allocation of module array in megan extension 

    "Array_16" was previously allocated and initialized twice.

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
    @lizziel
    lizziel committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    fb0a74d View commit details
    Browse the repository at this point in the history