[PULL REQUEST] Remove double counting of acetone from monoterpenes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dylan B. Millet <dbm@umn.edu>
yantosca
changed the title
yantosca
added
category: Bug
christophkeller
added a commit
to GEOS-ESM/HEMCO
that referenced
this pull request
Jul 30, 2021
|
This is an update that will affect science, so it will ship with HEMCO feature version 3.2.0. |
yantosca
approved these changes
Aug 4, 2021
|
This update has been merged into |
|
This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue. |
|
Closing due to inactivity |
|
I am keeping this PR open. This is going into the next version of HEMCO (3.2.0), which will be included in GEOS-Chem 13.3.0. |
yantosca
added a commit
to geoschem/GCClassic
that referenced
this pull request
Jan 21, 2022
This commit informs the GCClassic superproject about the following commits that were pushed to the Github geoschem/geos-chem repository: f31ffd6 Final cleanup 570eb98 Use standard solution not GEOS solution for ensuring LevDct_Unit is defined 5a98989 Prevent undefined variable when calculating vertical scale factor 27093bd Merge branch 'dev' into feature/ewlundgr/hemco_3.2.2_in_geos 06dfdc8 Merge branch 'feature/no_more_empty_error_messages' into dev d1fa54b Catch a few undefined uses of LOC 1377d0a Remove CMake command to enable OpenMP by default cd41222 Merge remote-tracking branch 'upstream/main' into feature/ewlundgr/hemco_3.2.2 4ee0bd7 Few lines added to hco_types_mod.F90 and mom6_cmake/CMakeLists.txt for succesful build 141a414 remove VFEI code since not yet operational 3f76bd0 Add SO4 to VFEI 28e5393 Get soil NOx restart files on every run call rather than just at the beginning 53ab3f7 Declare HEMCO restart field as missing if all values are negative, rather than all zeros 6a58b8f Use internal day tracker instead of HEMCO clock for updating volcano emissions e96c130 Add description and make PBL fraction and max. emission height a configurable parameter 0b211cf Add VFEI biomass burning extension 03c7b00 Merge branch 'geos/develop' of https://github.com/GEOS-ESM/HEMCO into geos/develop a6a5e76 Updates in support of 3km GEOSchem run fd0222b Make sure that HEMCO level unit is always defined 27ce8e8 Fast-track bug fix for biogenic acetone double-counting (geoschem/HEMCO#93) 7ede721 prevent undefined variable when calculating vertical scale factor 6bd123e Merge branch 'geoschem/3.0' into feature/elundgren/update_to_3.0 5365483 Merge pull request #6 from GEOS-ESM/bugfix/mathomp4/remove-redundant-files 8f2a4e8 HEMCO structural updates, including header name changes, build updates, and updates to precision settings. This brings various updates that facilitate HEMCO running within the NASA GEOS ESM. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added a commit
to geoschem/GCHP
that referenced
this pull request
Jan 21, 2022
This commit informs the GCHP superproject about the following commits that were pushed to the Github geoschem/geos-chem repository: f31ffd6 Final cleanup 570eb98 Use standard solution not GEOS solution for ensuring LevDct_Unit is defined 5a98989 Prevent undefined variable when calculating vertical scale factor 27093bd Merge branch 'dev' into feature/ewlundgr/hemco_3.2.2_in_geos 06dfdc8 Merge branch 'feature/no_more_empty_error_messages' into dev d1fa54b Catch a few undefined uses of LOC 1377d0a Remove CMake command to enable OpenMP by default cd41222 Merge remote-tracking branch 'upstream/main' into feature/ewlundgr/hemco_3.2.2 4ee0bd7 Few lines added to hco_types_mod.F90 and mom6_cmake/CMakeLists.txt for succesful build 141a414 remove VFEI code since not yet operational 3f76bd0 Add SO4 to VFEI 28e5393 Get soil NOx restart files on every run call rather than just at the beginning 53ab3f7 Declare HEMCO restart field as missing if all values are negative, rather than all zeros 6a58b8f Use internal day tracker instead of HEMCO clock for updating volcano emissions e96c130 Add description and make PBL fraction and max. emission height a configurable parameter 0b211cf Add VFEI biomass burning extension 03c7b00 Merge branch 'geos/develop' of https://github.com/GEOS-ESM/HEMCO into geos/develop a6a5e76 Updates in support of 3km GEOSchem run fd0222b Make sure that HEMCO level unit is always defined 27ce8e8 Fast-track bug fix for biogenic acetone double-counting (geoschem/HEMCO#93) 7ede721 prevent undefined variable when calculating vertical scale factor 6bd123e Merge branch 'geoschem/3.0' into feature/elundgren/update_to_3.0 5365483 Merge pull request #6 from GEOS-ESM/bugfix/mathomp4/remove-redundant-files 8f2a4e8 HEMCO structural updates, including header name changes, build updates, and updates to precision settings. This brings various updates that facilitate HEMCO running within the NASA GEOS ESM. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
category: Bug Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dylan B. Millet dbm@umn.edu