Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atanas Trayanov (GMAO) History updates: monthly diag fix, timestampStart #9

Merged
merged 1 commit into from Apr 20, 2021

Conversation

lizziel
Copy link

@lizziel lizziel commented Apr 16, 2021

This PR contains updates from Atanas Trayanov (GMAO) for the following features/bug fixes:

  • Diagnostic file time attribute 'time_increment' is now fixed for monthly diagnostics configured in HISTORY.rc with collection.monthly: 1. For monthly time-averaged files it is set to # of days in month.
  • Diagnostic filenames can optionally be set to contain start rather than mid-point datetime for time-averaged collections. Configure in HISTORY.rc with collection.timestampStart: .true..

These changes are currently in GEOS-ESM/MAPL branch develop. I manually added them to geoschem/MAPL so that we can get them prior to the next MAPL version update in GCHP.

I have tested these changes but have a couple more tests to complete before merging.

- Diagnostic file time attribute 'time_increment' is now fixed for
  monthly diagnostics configured in HISTORY.rc via {collection}.monthly: 1
  For monthly time-averaged files it is set to # of days in month.
- Diagnostic filenames can optionally be set to contain start rather than
  mid-point datetime for time-averaged collections. Configure in HISTORY.rc
  with {collection}.timestampStart: .true.

These updates are in GMAO MAPL branch develop but are manually added here
so that we can get the functionality before the next MAPL version update.

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel self-assigned this Apr 20, 2021
@lizziel lizziel merged commit a464a1b into gchp/dev Apr 20, 2021
@lizziel lizziel deleted the feature/timestampStart_and_monthlyDiagFix branch May 5, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant