Skip to content

Commit

Permalink
Fixes for minor bugs that prevented TOMAS from building & running
Browse files Browse the repository at this point in the history
GeosCore/gamap_mod.F90: Fixed a formatting error in routine WRITE_TINFO.
When the moles C/moles species value was removed, this caused a mismatch
in the format statement.  We now write "1" as a placeholder, which
eliminates the formatting error.

run/shared/setupConfigFiles.sh: The line "Use non-local PBL" ws changed
to " => Use non-local PBL", so the "replace_colon_sep_val" search &
replace function was missing this.  We have now fixed it so that
replace_colon_sep_val now looks for the proper text.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
  • Loading branch information
yantosca committed Jan 15, 2021
1 parent 82dad41 commit 1e481bb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
12 changes: 8 additions & 4 deletions GeosCore/gamap_mod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ END SUBROUTINE DO_GAMAP
!\\
! !INTERFACE:
!
SUBROUTINE CREATE_DINFO
SUBROUTINE CREATE_DINFO()
!
! !USES:
!
Expand Down Expand Up @@ -537,9 +537,13 @@ SUBROUTINE WRITE_TINFO( IU_FILE, NAME, FNAME, MWT, SCALE, UNIT, N )
! WRITE_TINFO begins here!
!=================================================================

! Write one line to "tracerinfo.dat" file
WRITE( 6, 100, IOSTAT=IOS ) &
ADJUSTL( NAME ), ADJUSTL( FNAME ), MWT, 1, N, SCALE, TRIM( UNIT )

! Write one line to "tracerinfo.dat" file
WRITE( IU_FILE, 100, IOSTAT=IOS ) &
ADJUSTL( NAME ), ADJUSTL( FNAME ), MWT, N, SCALE, TRIM( UNIT )
ADJUSTL( NAME ), ADJUSTL( FNAME ), MWT, 1, N, SCALE, TRIM( UNIT )

! Error check
IF ( IOS /= 0 ) CALL IOERROR( IOS, IU_FILE, 'write_tinfo:1' )
Expand Down Expand Up @@ -656,7 +660,7 @@ END SUBROUTINE WRITE_SEPARATOR
!\\
! !INTERFACE:
!
SUBROUTINE INIT_DIAGINFO
SUBROUTINE INIT_DIAGINFO()
!
! !REVISION HISTORY:
! 17 Oct 1996 - R. Yantosca - Initial version
Expand Down Expand Up @@ -5054,7 +5058,7 @@ SUBROUTINE INIT_GAMAP( Input_Opt, State_Chm, RC )
!=================================================================

! Initialize arrays for "diaginfo.dat"
CALL INIT_DIAGINFO
CALL INIT_DIAGINFO()

! Initialize arrays for "tracerinfo.dat"
CALL INIT_TRACERINFO( Input_Opt, State_Chm, RC )
Expand Down
2 changes: 1 addition & 1 deletion run/shared/setupConfigFiles.sh
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ Species name : MOPO"
# TOMAS settings
#------------------------------------------------------------------------
if [[ ${sim_extra_option} =~ "TOMAS" ]]; then
replace_colon_sep_val "Use non-local PBL?" F input.geos
replace_colon_sep_val " => Use non-local PBL?" F input.geos
replace_colon_sep_val "Use linear. strat. chem?" F input.geos
replace_colon_sep_val "=> Online O3 from model" F input.geos
replace_colon_sep_val "TOMAS_Jeagle" on HEMCO_Config.rc
Expand Down

0 comments on commit 1e481bb

Please sign in to comment.