Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG/ISSUE] Incorrect 'time' dimension in EDGAR v6 #1484

Closed
ruosiliang opened this issue Nov 6, 2022 · 2 comments · Fixed by #1507
Closed

[BUG/ISSUE] Incorrect 'time' dimension in EDGAR v6 #1484

ruosiliang opened this issue Nov 6, 2022 · 2 comments · Fixed by #1507
Assignees
@msulprizio
Labels
category: Bug Something isn't working topic: Input Data Related to input data
Milestone
14.0.2

Comments

@ruosiliang
Copy link

Description of the problem

I downloaded EDGAR v6 from http://geoschemdata.wustl.edu/ExtData/HEMCO/CH4/v2022-01/EDGARv6 . I find the values of the coordinate 'time' are incorrect. For example, the time of the file 'v6.0_CH4_2018_AGS.0.1x0.1.nc' is [2395-05-18, 2395-6-18, ... ,2396-04-16]
捕获

This incorrect time caused the methane simulation to use the wrong file. For example, GEOS-Chem always read the first slice (time = '2395-05-18') of 'v6.0_CH4_2018_AGS.0.1x0.1.nc' during the period from 2018.1 to 2018.6

The cause of this error seems to be in the process EDGAR v6.0 CH4 emissions file: EDGARv6_CH4_edit.sh.

for YEAR in {2000..2018}; do

    for SECTOR in ${SECTORS[@]}; do
    
        for MONTH in {1..12}; do

             ....
        
             MONTHTAU=${TAUS[$MONTH-1]}
             TAU=$(($TAU + $MONTHTAU))

When a sector is finished, 'TAU' should be reset to January of the current year, but the code does not.

GEOS-Chem version

12.9.3
@ruosiliang ruosiliang added the category: Bug Something isn't working label Nov 6, 2022
@msulprizio msulprizio self-assigned this Nov 7, 2022
@yantosca yantosca added the topic: Input Data Related to input data label Nov 7, 2022
@msulprizio
Copy link
Contributor

Thanks for reporting this issue @ruosiliang. I can confirm this bug on our end as well. I will reprocess the EDGAR v6 CH4 files and aim to push a fix for 14.0.2.

@msulprizio msulprizio added this to the 14.0.2 milestone Nov 7, 2022
msulprizio added a commit that referenced this issue Nov 15, 2022
@msulprizio
Update EDGARv6 files for CH4 simulations to fix timestamp bug
c3a8565 
As reported in #1484, the
files in HEMCO/CH4/v2022-01/EDGARv6 had the incorrect timestamps which
caused data for the wrong date to be used in CH4 simulations. The files
have been reprocessed and the corrected files may be found in
HEMCO/CH4/v2022-11/EDGARv6. Here we update the filepaths in HEMCO_Config.rc
for CH4 and tagCH4 simualtions to use the corrected files.

Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
msulprizio added a commit that referenced this issue Nov 15, 2022
@msulprizio
Update EDGARv6 files for CH4 simulations to fix timestamp bug
fe88566 
As reported in #1484, the
files in HEMCO/CH4/v2022-01/EDGARv6 had the incorrect timestamps which
caused data for the wrong date to be used in CH4 simulations. The files
have been reprocessed and the corrected files may be found in
HEMCO/CH4/v2022-11/EDGARv6. Here we update the filepaths in HEMCO_Config.rc
for CH4 and tagCH4 simualtions to use the corrected files.

Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
@msulprizio msulprizio mentioned this issue Nov 15, 2022
Merged
@msulprizio
Copy link
Contributor

The corrected files can now be found in HEMCO/CH4/v2022-11/EDGARv6.

See the corresponding PR #1507 for a summary of the differences (table and maps) caused by fixing the EDGAR v6 CH4 files.

@msulprizio msulprizio linked a pull request Nov 15, 2022 that will close this issue
Add fix for EDGAR v6 CH4 emissions #1507
Merged
yantosca added a commit that referenced this issue Nov 16, 2022
@yantosca
Update EDGARv6 files for carboncycle simulations to fix timestamp bug
2452f62 
As reported in #1484, the
files in HEMCO/CH4/v2022-01/EDGARv6 had the incorrect timestamps which
caused data for the wrong date to be used in CH4 simulations.

We have updated the path to the EDGARv6 data in the HEMCO_Config.rc
and ExtData.rc template files for the carboncycle simulation following
the fix by Melissa Sulprizio in geoschem/geos-chem PR #1507

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msulprizio msulprizio

Labels
category: Bug Something isn't working topic: Input Data Related to input data
Projects
None yet
Milestone
14.0.2
Development

Successfully merging a pull request may close this issue.

Add fix for EDGAR v6 CH4 emissions geoschem/geos-chem
3 participants
@msulprizio @yantosca @ruosiliang