Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] ALK4 and R4N2 chemistry from Brewer et al. (2023) #1625

Closed
msulprizio opened this issue Jan 26, 2023 · 4 comments · Fixed by #2352
Closed

[FEATURE REQUEST] ALK4 and R4N2 chemistry from Brewer et al. (2023) #1625

msulprizio opened this issue Jan 26, 2023 · 4 comments · Fixed by #2352
Assignees
@msulprizio
Labels
Attn: Chemistry WG Attention: Chemistry Working Group category: Bug Something isn't working category: Feature Request New feature or request topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms
Milestone
14.5.0

Comments

@msulprizio
Copy link
Contributor

msulprizio commented Jan 26, 2023 •
edited
Loading

R4N2 was a common product of alkane, isoprene, and monoterpene oxidation and produced organonitrate SOA but we don’t want ALK4 to produce organonitrate SOA. Jared Brewer has implemented a fix to address this.

Reference

Brewer, J.F., D.J. Jacob, S.H. Jathar, Y. He, A. Akherati, S. Zhai, D.S. Jo, A. Hodzic, B.A. Nault, P. Campuzano-Jost, J.L. Jimenez, R.J. Park, Y.J. Oak, and H. Liao, A scheme for representing aromatic secondary organic aerosols in chemical transport models: application to source attribution of organic aerosols over South Korea during the KORUS-AQ campaign, J. Geophys. Res., e2022JD037257, https://doi.org/10.1029/2022JD037257, 2023.
@msulprizio msulprizio added category: Feature Request New feature or request topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms labels Jan 26, 2023
@msulprizio msulprizio added this to the 14.2.0 milestone Jan 26, 2023
@yantosca Octobox
Copy link
Contributor

@msulprizio, do we have code for this or do we have to manually edit the KPP *.eqn file from the paper?

@msulprizio
Copy link
Contributor Author

I've emailed Jared to get these code updates. We do not have them yet.

@msulprizio msulprizio modified the milestones: 14.2.0, In progress Mar 27, 2023
@msulprizio
Copy link
Contributor Author

@JFBrewer is there any update on this? Could you create a pull request with these updates or point us to your code?

@msulprizio msulprizio changed the title [FEATURE REQUEST] ALK4 and R4N2 chemistry from Brewer et al. (submitted) [FEATURE REQUEST] ALK4 and R4N2 chemistry from Brewer et al. (2023) Apr 18, 2024
@msulprizio msulprizio added category: Bug Something isn't working Attn: Chemistry WG Attention: Chemistry Working Group labels Jun 26, 2024
@msulprizio msulprizio added this to the 14.5.0 milestone Jun 26, 2024
@msulprizio msulprizio self-assigned this Jun 26, 2024
msulprizio added a commit that referenced this issue Jun 26, 2024
@msulprizio
Add fixes for ALK4 and R4N2 chemistry from Brewer et al. (2023, JGR)
5709742 
R4N2 was a common product of alkane, isoprene, and monoterpene oxidation
and produced organonitrate SOA but we don’t want ALK4 to produce
organonitrate SOA as discusses in #1625.
A fix from Jared Brewer is included here.

NOTE: The KPP fullchem mechanism has not been rebuilt with these fixes to
facilitate merging these updates up to the latest GEOS-Chem release. These
updates will also need to be added to the custom.eqn file.

Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
@msulprizio msulprizio mentioned this issue Jun 26, 2024
Merged
@msulprizio msulprizio linked a pull request Jun 26, 2024 that will close this issue
Add fixes for ALK4 and R4N2 chemistry from Brewer et al. (2023, JGR) #2352
Merged
yantosca added a commit that referenced this issue Aug 1, 2024
@yantosca
Merge PR #2352 (Fixes for ALK4 and R4N2 chemistry from J. Brewer)
0a392d4 
This merge brings PR #2352 (Add fixes for ALK4 and R4N2 chemistry from
Brewer et al. (2023, JGR), by @msulprizio) into the GEOS-Chem 14.5.0
development stream.

R4N2 was a common product of alkane, isoprene, and monoterpene oxidation
and produced organonitrate SOA but we don’t want ALK4 to produce
organonitrate SOA as discusses in #1625. A fix from Jared Brewer is
included here.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca
Copy link
Contributor

yantosca commented Aug 1, 2024

We can now close this issue as PR #2352 has been merged into the GEOS-Chem 14.5.0 development stream.

@yantosca yantosca closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msulprizio msulprizio

Labels
Attn: Chemistry WG Attention: Chemistry Working Group category: Bug Something isn't working category: Feature Request New feature or request topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms
Projects
None yet
Milestone
14.5.0
Development

Successfully merging a pull request may close this issue.

Add fixes for ALK4 and R4N2 chemistry from Brewer et al. (2023, JGR) geoschem/geos-chem
2 participants
@msulprizio @yantosca