New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planeflight AOD diagnostics appear to be malfunctioning (GC 12.7) [BUG/ISSUE] #294
Comments
Thanks for writing. We will look into this. I wonder if this is somehow related to #293. |
I took a look at the planeflight code (see this permalink). geos-chem/GeosCore/planeflight_mod.F90 Lines 1849 to 1983 in e3b3b65
I think there are a few things wrong here: First, the aerosols & dust are lumped together. That would be fine for total AOD but not if you want to get the individual contributions. Secondly, we are using the ODAER and ODMDUST arrays, which are computed in GeosCore/aerosol_mod.F (or .F90 in 12.8.0). But these arrays hold total aerosol AOD and total dust AOD because they are summed into over all aerosol/dust species. This is where ODAER is summed into over aerosols: geos-chem/GeosCore/aerosol_mod.F90 Lines 1608 to 1664 in e3b3b65
and over dust: geos-chem/GeosCore/dust_mod.F90 Lines 1323 to 1351 in e3b3b65
So long story short, there aren't any arrays that store the individual contributions for aerosol & dust AOD's. You would have to add these and populate them in aerosol_mod and dust_mod. The planeflight diagnostic is kind of old by now. I am not sure if this ever worked properly, or if it did once and then fell out of step with other model updates since then. |
Ok, that makes sense, given the values output here. Thank you Bob! I have 2 additional qs:
Thanks, |
The ODAER and ODMDUST are grid box AOD's (since we feed them into FAST-JX). But if you sum them in the vertical you'll get column AOD. We have no plans to remove Planeflight for the time being, as several people still use it. ObsPack is also a similar diagnostic (and you can use it) but you'd have to convert the input file to the netCDF format that it expects. Also I think ObsPack can save some meteorology and species concs by default but maybe not the AODs. So your I think your best bet would be to hack Planeflight etc. so that it saves out what you want. |
I am going to close out this issue but feel free to reopen if you have further questions. |
That's fine. I'm going to make an edit to the wiki updating the relevant
section. Thank you.
…On Wed, May 13, 2020 at 2:36 PM Bob Yantosca ***@***.***> wrote:
I am going to close out this issue but feel free to reopen if you have
further questions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#294 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADDHZDB6SGRRRWOHFAQRK6LRRMADTANCNFSM4MZ4KASQ>
.
|
Shixian Zhai (@zsx-GitHub) wrote:
|
This fix is now merged into our development code in commit 4a3d1b9 and will be included in 12.9.0. |
Hi @msulprizio & others, I've just stumbled across this after encountering the same problem in an older v12 we are running, and I am concerned that the "fix" actually changes the diagnostic outputs so that they no longer match the descriptions given on the wiki (as well as the meaning historically given to these diagnostics). AODC should be the total column optical depth but is now grid-box AOD, and AODB should be below the aircraft but is now above. I suggest that we change these back to their original meaning. This would mean:
If there is a desire for single grid box AOD or above plane AOD it would be easy enough to just add those as additional diagnostics, but the current disconnect is problematic IMO. Cheers, |
Dear Jenny Fisher & others, I agree with Jenny that descriptions given on wiki page should match the model to avoid confusion. We can either add additional diagnostics or just edit the wiki. It might be better to use names like AODG and AODA to respectively represent grid-box AOD and above grid AOD. Best, |
Hi @msulprizio & @zsx-GitHub -- I discovered another potential issue in the new version: the individual AOD tracers (e.g. AODC_SULF, AODC_BLKC, etc.) do not sum to the total AOD. This is because when using any simulation that uses UCX (e.g. Standard), there are two stratospheric aerosol tracers. These aren't accounted for explicitly (but were included in the buggy version that looped over all aerosol species). I think it is likely that users will want to be able to get the total AOD in addition to the individual tracers (as this is what is likely measured). I have a version that adds this as tracer 2007 for total column AODC (haven't messed with AODB as we don't need that for our sims). It's based on a slightly earlier model version, but should be easy to adapt. Let me know if you want it. -Jenny |
Hi @jennyfisher. Thanks for following up with the solution. Please do share your fix and we can include it in a future version. |
Hi @msulprizio - Our current version of planeflight_mod.F90 is attached (had to zip for github to accept). A couple of quick notes:
I'm happy to take a look at an updated version of this code to look for any issues! -Jenny |
Here we add updates from Jenny Fisher to include total column AOD as an option for planeflight output. We also add similar updates to include total AOD below the plane. In addition, we have restored the code so that it is consistent with the descriptions on the wiki. That is, we loop over all levels, instead of obtaining AOD for a single level. We also restore the AODB diagnostics so that they are below plane, not above plane to avoid confusion. Original message from Jenny Fisher (Github issue #294): I discovered another potential issue in the new version: the individual AOD tracers (e.g. AODC_SULF, AODC_BLKC, etc.) do not sum to the total AOD. This is because when using any simulation that uses UCX (e.g. Standard), there are two stratospheric aerosol tracers. These aren't accounted for explicitly (but were included in the buggy version that looped over all aerosol species). I think it is likely that users will want to be able to get the total AOD in addition to the individual tracers (as this is what is likely measured). I have a version that adds this as tracer 2007 for total column AODC (haven't messed with AODB as we don't need that for our sims). A couple of quick notes: 1. This version is based on 12.8 code. We manually implemented the fix to AODC, but in our case this represents total column AOD rather than grid-box specific. This is consistent with the original meaning, implementation, and wiki documentation for AODC. It will be important to make sure that the new AODC_TOT (2007) matches the AODC_XXXX (2001:2006), so either change the others back to total column or change this one to single level (and in that case update the wiki). 2. We only updated AODC. Haven't touched AODB, so that still has the original bug that spawned this ticket. But it should be easy to start from the updates you already have for that one and just add the total AODB tracer similarly to what I've done for total AODC. 3. If AODB remains as above-plane AOD as Shixian implemented it, then the wiki page should really be updated. Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
Hi @jennyfisher. We've finally implemented your updates in planeflight_mod.F90 to include total AOD. See commit 6e14981. I also added |
Great, thanks! |
Hi folks,
I've been playing around with the planeflight diagnostic outputs recently, and I think I've found a bug. On this wiki page, it suggests that the planeflight diagnostic can output 6 different AOD variables (dust, sulfate, black carbon, organic carbon, sea salt in 2 modes) for both the column and below the aircraft. However, when I output these variables, all 12 options give the exact same value at every point. It would appear to me that they may not be being properly updated by the model. I'm not sure whether the given value is a total AOD value or if it's just one of the 12 diagnostics being applied in all cases.
I've attached one of my Planeflight.dat files and the corresponding output file from May 1, 2016. This was created using GC v12.7.1 and a custom quarter degree nested run set up over Korea.
Planeflight_Bug_Report.zip
Jared
The text was updated successfully, but these errors were encountered: