New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added native versions of GEOS-FP as menu options in GCHP run directory creation #1230
Conversation
…o be handled by init_rd.sh. Added GEOS-FP native meteorology as a menu option for the meteorology source.
…gs for metfield exports.
…ulation types in createRunDir.sh
This is ready to merge @msulprizio. This adds "GEOS-FP native data" as an option to "Choose meteorology source:". If you select it, it also asks
The metfields for mass fluxes and mass flux derived winds are available here: http://geoschemdata.wustl.edu/ExtData/GEOS_C720/ (I'll add them to the input data catalogs once I've finished processing the backlog). FYI, @sdeastham. Based on your response, it will initialize the run directory appropriately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon further review and testing, I've found these updates break GCClassic run directory creation. I think this may be because of lines added to run/shared/settings/geosfp.txt
and run/shared/settings/merra2.txt
. We are therefore going to have to exclude this update from the 14.0.0 release candidate.
@LiamBindle Could you please test this with both GCClassic and GCHP and push any fixes? PRs should pass integration tests for both GCClassic and GCHP before merging.
…re the shared metfield variables (which use RUNDIR_GRID_DIR). Previously, erroneous sort was getting correct order by mistake.
Sorry about that @msulprizio. I forgot to add an update to the copy of I don't have the capability to run integration tests. Are you guys able to run that easily? |
…nt variables are resolved correctly.
I should note I confirmed there's no difference in GEOS-FP or GCAP2 run directories with GC-Classic between alpha.3 and after this update. 006f7fa should make it so the order of RUNDIR_ variables doesn't matter. |
@LiamBindle Thanks for pushing those fixes. I tested on my end and this looks good to merge now. |
Thanks Melissa! |
This is a WIP. I'll add more in the coming days.
Things I need to check