Avoid compiler warning and compilation restart for KPP/fullchem/gckpp_Jacobian.F90 #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPP/fullchem/gckpp_Jacobian.F90 - Since the fullchem mechanism was rebuilt with KPP 3.0.0, a compiler warning is triggered that there are too many variables to keep track for certain debug information. We have added code to the CMakeLists.txt file in KPP/fullchem to disable this compilation feature when creating the "release" build with GNU Fortran. This should save compilation time, as when the warning is encountered, the compilatio of the KPP/fullchem code is restarted. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
category: Bug
|
Compiling with make VERBOSE=1 shows that the proper flag ( ... etc not shown ...
-fdefault-real-8 -fdefault-double-8 -cpp -w -std=legacy -fautomatic -fno-align-commons -fconvert=big-endian
-fno-range-check -mcmodel=medium -fbacktrace -g -DLINUX_GFORTRAN -ffree-line-length-none -O3
-funroll-loops -fopenmp -fno-var-tracking-assignments
-c /local/ryantosca/GC/rundirs/epa-kpp/test_build/CodeDir/src/GEOS-Chem/KPP/fullchem/gckpp_Jacobian.F90
-o CMakeFiles/KPP.dir/gckpp_Jacobian.F90.o |
|
GEOS-Chem Classic integration tests all passed ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #19bdf09 GEOS-Chem submod update: Merge PR #1643 and PR #1644 into 14.1.1
GEOS-Chem #6afa713f6 Avoid compiler warning and compilation restart for gckpp_Jacobian.F90
HEMCO #16541aa Update changelog for version release
Using 24 OpenMP threads
Number of execution tests: 26
Submitted as SLURM job: 42518927
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS
gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem..........................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS15..................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS40..................Execute Simulation....PASS
gc_4x5_merra2_aerosol...............................Execute Simulation....PASS
gc_4x5_merra2_carbon................................Execute Simulation....PASS
gc_4x5_merra2_CH4...................................Execute Simulation....PASS
gc_4x5_merra2_CO2...................................Execute Simulation....PASS
gc_4x5_merra2_fullchem..............................Execute Simulation....PASS
gc_4x5_merra2_fullchem_aciduptake...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_APM..........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_benchmark....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA_SVPOA.............Execute Simulation....PASS
gc_4x5_merra2_fullchem_LuoWd........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_marinePOA....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_RRTMG........................Execute Simulation....PASS
gc_4x5_merra2_Hg....................................Execute Simulation....PASS
gc_4x5_merra2_metals................................Execute Simulation....PASS
gc_4x5_merra2_POPs_BaP..............................Execute Simulation....PASS
gc_4x5_merra2_tagCH4................................Execute Simulation....PASS
gc_4x5_merra2_tagCO.................................Execute Simulation....PASS
gc_4x5_merra2_tagO3.................................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers......................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers_LuoWd................Execute Simulation....PASS
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 26
Execution tests failed: 0
Execution tests not yet completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
run/GCHP/createRunDir.sh
- The "Created ${rundir}" sentence was being printed out twice. This
was causing issues in the GCHP integration tests because the
"create_rundir" script in test/shared/commonFunctionsForTests.sh
looks for this output to get the absolute path of the run directory.
This was causing text replacement in the ./setCommonRunSettings.sh
script not to be done correctly. Now fixed.
Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
|
GCHP integration tests failed due to a bug in the |
lizziel
reviewed
Feb 17, 2023
KPP/fullchem/CMakeLists.txt
Outdated
| @@ -61,3 +61,17 @@ target_compile_options(KPP | |||
| $<$<STREQUAL:"${CMAKE_Fortran_COMPILER_ID}","Intel">:-r8> | |||
| $<$<STREQUAL:"${CMAKE_Fortran_COMPILER_ID}","GNU">:-fdefault-real-8 -fdefault-double-8> | |||
| ) | |||
|
|
|||
| # FOR GFORTRAN ONLY: Disable variable tracking for gckpp_Jacobian.F90 in the | |||
| # KPP/fullchem mechanism generated with KPP 3.0.0. This will avoid a compiler | |||
There was a problem hiding this comment.
Maybe we should remove the version number so that the text doesn't get outdated.
There was a problem hiding this comment.
Thanks @lizziel. I can do that.
lizziel
approved these changes
Feb 17, 2023
|
GCHP execution tests all passed except tagO3. There is an outstanding issue in that simulation that we need to address, ==============================================================================
GCHP: Execution Test Results
GCClassic #646fce2 Fixed MAPL bug preventing restarting stretched grid simulations
GEOS-Chem #5cf1ae03a Remove duplicate "Created rundir" printout in run/GCHP/createRunDir.sh
HEMCO #cf7d4ed GEOS-only updates by Christoph Keller
Number of execution tests: 5
Submitted as SLURM job: 42707332
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gchp_merra2_fullchem................................Execute Simulation....PASS
gchp_merra2_fullchem_benchmark......................Execute Simulation....PASS
gchp_merra2_fullchem_RRTMG..........................Execute Simulation....PASS
gchp_merra2_tagO3...................................Execute Simulation....FAIL
gchp_merra2_TransportTracers........................Execute Simulation....PASS
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 4
Execution tests failed: 1
Execution tests not yet completed: 0 |
KPP/fullchem/CMakeLists.txt - Removed "3.0.0" from comment so as not to "peg" this modification to a specific version of KPP. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling the
KPP/fullchemmechanism generated with KPP 3.0.0, we often get this compiler warning:This indicates that the compilation is being restarted because the optimizer cannot keep track of the number of variable definitions in
gckpp_Jacobian.F90. This causes compilation to take longer.To avoid this, we have added code to the
KPP/fullchem/CMakeLists.txtto prevent this compiler warning whenKPP/fullchem/gckpp_Jacobian.F90is being compiled. The code is only activated when building theReleaseorRelWithDebugInfobuild types, as these options invoke the GNU Fortran optimizer, whereasDebugdoes not.