Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GCHP check for python and bc libs to prevent error checking fail #1777

Merged
merged 1 commit into from Apr 26, 2023
Merged

Update GCHP check for python and bc libs to prevent error checking fail #1777

merged 1 commit into from Apr 26, 2023

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Apr 25, 2023

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Confirm you have reviewed the following documentation

Describe the update

The PR prevents setCommonRunSettings.sh from failing if either the bc or python libraries are not found. This is necessary because of a recent update that added set -e to the script, causing the script to stop if any command has return status other than 0.

Expected changes

No failure running setCommonRunSettings.sh if which bc or which python fail.

Related Github Issue(s)

#1762

@lizziel
Update GCHP check for python and bc libs to prevent error checking fail
1e8e405 
Previously setCommonRunSettings.sh would fail if either of the libraries
were not found. This was only the case since a recent update to include
set -e in the script to catch command errors.

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel added topic: GCHP Related to GCHP only topic: Configuration Files Related to GEOS-Chem configuration files labels Apr 25, 2023
@lizziel lizziel added this to the 14.2.0 milestone Apr 25, 2023
@lizziel lizziel requested a review from yantosca April 25, 2023 17:21
@lizziel lizziel self-assigned this Apr 25, 2023
@lizziel lizziel changed the base branch from dev/14.2.0 to main April 25, 2023 17:22
@msulprizio msulprizio changed the base branch from main to dev/14.2.0 April 26, 2023 11:48
@lizziel lizziel marked this pull request as ready for review April 26, 2023 14:06
yantosca
yantosca approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple bug fix that sets the value of bc_ok and py_ok to zero before it is used. This will prevent GCHP from dying if python is not found on the system. Good to merge.

@msulprizio msulprizio linked an issue Apr 26, 2023 that may be closed by this pull request
GCHP rundir script setCommonRunSettings.sh fails on "which python" if python is not installed on the node #1762
Closed
4 tasks
@msulprizio msulprizio merged commit f3c103e into dev/14.2.0 Apr 26, 2023
@msulprizio msulprizio deleted the bugfix/allow_missing_python_library branch April 26, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yantosca yantosca Awaiting requested review from yantosca

Assignees

@lizziel lizziel

Labels
topic: Configuration Files Related to GEOS-Chem configuration files topic: GCHP Related to GCHP only
Projects
None yet
Milestone
14.2.0
Development

Successfully merging this pull request may close these issues.

GCHP rundir script setCommonRunSettings.sh fails on "which python" if python is not installed on the node
3 participants
@lizziel @yantosca @msulprizio