Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for transport tracers simulation #1890

Merged
merged 5 commits into from
Jul 28, 2023

Commits on Jul 26, 2023

  1. Define MW_g for all transport tracer species

    Transport tracer species aoa*, nh*, St80_25, and StOX did not have molecular
    weights defined because they're not traditional chemical species. This causes
    issues with unit conversions in the code and results in negative and/or
    zero SpeciesConc output. To avoid this, we define MW_g: 1.0 for those
    species.
    
    Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
    msulprizio committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9dbf84b View commit details
    Browse the repository at this point in the history
  2. Add several fixes for transport tracers in tracer_mod.F90

    1. Move initialization of mask arrays into loop over species.
    2. Make sure to do calculations for maintaining the mixing ratio only in the defined region (where Mask is 1)
    3. Fix typo in the logic for determining masks of latitude zones.
    
    Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
    msulprizio committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    fb97580 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Remove stOX from TransportTracers simulation

    The stOX tracer is defined in GMAO's TR_GridComp but is not commonly utilized
    and isn't needed in GEOS-Chem. It is removed here to avoid confusion. The
    fields needed for stOX (GLOBAL_O3 and O3_LOSS) are also removed from
    tracer_mod.F90 and TransportTracer configuration files.
    
    Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
    msulprizio committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2c2456f View commit details
    Browse the repository at this point in the history
  2. Add fixes for masking in tracer_mod.F90

    Instead of multiplying the source or sink application by the Mask array,
    the code now checks if Mask > 0 before applying the source or sink.
    Multiplying by the Mask array may have inadvertently set species concentrations
    to zero instead of not implying the source or sink.
    
    Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
    msulprizio committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    b8323f8 View commit details
    Browse the repository at this point in the history
  3. Disable Budget diagnostics for TransportTracers simulations

    The Budget diagnostics collection is now needed for TransportTracer benchmarking.
    It is now disabled by default to avoid saving out unnecessary data.
    
    Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
    msulprizio committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    5cee298 View commit details
    Browse the repository at this point in the history