Restore consideration of sea salt alkalinity to heterogenerous acid-catalyzed reactions of halogens on sea salt aerosols (now fixing typos) #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cid* functions In fullchem_RateLawFuncs.F90, the arguments passed to function Ars_L1k were not in the correct order - area, radius, gamma, srMw. In the following functions, gamma and srMw were swapped: - IuptkbyAlkSALA1stOrd - IuptkByAlkSALC1stOrd - IbrkdnbyAcidBrSALA - IbrkdnbyAcidBrSALC - IbrkdnbyAcidSALACl - IbrkdnbyAcidSALCCl These typos were introduced in the original PRs (#1548, #1702) for these bug fixes, possible because the fixes were implemented off of an older version of GEOS-Chem (13.4.1). Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
msulprizio
added
category: Bug
This was
linked to
issues
Sep 11, 2023
yantosca
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Hi @msulprizio. Thanks for this. I don't quite see where the incorrect argument sequences were. Were they in the IuptkBySALA1stOrd and IuptkBySALC1stOrd functions? Thanks.
yantosca
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Never mind @msulprizio. I understand now. Thanks for the fix! Good to merge.
…#1933 Arguments for id_SAL* needed to be added to fullchem_SetStateHet in stub_fullchem_HetStateFuncs.F90 for consistency with fullchem_HetStateFuncs.F90. Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
yantosca
approved these changes
Sep 11, 2023
|
All GCClassic and GCHP integration tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard/ GCST
Confirm you have reviewed the following documentation
Describe the update
This is the corresponding pull request to #1547, now fixing typos in the calls to Ars_L1K. In several calls to that routine the gamma and SrMW arguments were swapped, leading to integration errors in KPP. Fixing these, seems to get rid of the errors and allows us to properly restore consideration of sea salt alkalinity to heterogenerous acid-catalyzed reactions of halogens on sea salt aerosols.
Tagging @beckyalexander @viral211 @yantosca.
Expected changes
See the original description of the issue and fix in #1547.
Reference(s)
If this is a science update, please provide a literature citation.
Related Github Issue(s)