Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tags in geoschem_config.yml for nitrate aerosol photolysis as per GCSC suggestion #1998

Merged
merged 2 commits into from Feb 28, 2024

Conversation

yantosca
Copy link
Contributor

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Describe the update

This is the companion PR to #1968. We have renamed the YAML tags in geoschem_config.yml from:

    photolyze_nitrate_aerosol:
      activate: true
      NITs_Jscale_JHNO3: 100.0
      NIT_Jscale_JHNO2: 100.0

to

    photolyze_nitrate_aerosol:
      activate: true
      NITs_Jscale: 100.0
      NIT_Jscale: 100.0

as per discussion at the 19 Sep 2023 GEOS-Chem Steering Committee meeting.

Expected changes

This should be a zero-diff update. It can go into the next feature version, because it changes the geoschem_config.yml run directory configuration file.

Reference(s)

N/A

Related Github Issue(s)

run/CESM/geoschem_config.yml
run/GCClassic/geoschem_config.yml.templates/geoschem_config.yml.fullchem
run/GCHP/geoschem.config.yml.templates/geoschem_config.yml.fullchem
run/GEOS/geoschem_config.yml
- Rename NITs_Jscale_JHNO3 -> NITs_Jscale
- Rename NIT_Jscale_JHNO2 -> NIT_Jscale

GeosCore/input_mod.F90
- Updated YAML search keys accordingly

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added category: Feature Request New feature or request topic: Configuration Files Related to GEOS-Chem configuration files labels Oct 18, 2023
@yantosca yantosca linked an issue Oct 18, 2023 that may be closed by this pull request
1 task
@yantosca yantosca added the Attn: Chemistry WG Attention: Chemistry Working Group label Oct 18, 2023
@yantosca
Copy link
Contributor Author

All GEOS-Chem Classic integration tests except TOMAS passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #ad68c48 GEOS-Chem 14.2.1 and HEMCO 3.7.1 release
GEOS-Chem #15701ee41 Rename tags in geoschem_config.yml for nitrate aerosol photolysis
HEMCO     #00aaf65 Update HEMCO 3.7.1 release date in CHANGELOG.md

Using 24 OpenMP threads
Number of execution tests: 27

Submitted as SLURM job: 5205266
==============================================================================
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2
Execution tests not yet completed: 0

Also, all integration tests were zero-diff w/r/t 14.2.1 except for APM and RRTMG (diagnostic output only), which have known parallelization issues.

@yantosca
Copy link
Contributor Author

yantosca commented Oct 18, 2023

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCClassic #6413378 GEOS-Chem/GCHP 14.2.1 and HEMCO 3.7.1 release
GEOS-Chem #15701ee41 Rename tags in geoschem_config.yml for nitrate aerosol photolysis
HEMCO     #00aaf65 Update HEMCO 3.7.1 release date in CHANGELOG.md

Number of execution tests: 5

Submitted as SLURM job: 5206314
==============================================================================
 

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all integration tests were zero-diff w/r/t 14.2.1.

@msulprizio msulprizio changed the base branch from main to dev/no-diff-to-benchmark February 23, 2024 20:23
@msulprizio msulprizio changed the base branch from dev/no-diff-to-benchmark to dev/14.4.0 February 23, 2024 20:24
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straightforward update renaming NITs_Jscale_JHNO3 to NITs_Jscale and NIT_Jscale_JHNO2 to NIT_Jscale. Good to merge.

This merge brings the latest state of the GEOS-Chem 14.4.0 development
branch (as of PR #1979, aka 14.4.0-alpha.3) into the feature branch
for PR #1998 (Rename tags in geoschem_config.yml for nitrate aerosol
photolysis as per GCSC suggestion, by @yantosca)

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca
Copy link
Contributor Author

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #f261845 GEOS-Chem submodule update: Merge PR #1979 (Updated NOAA GMD surface BCs)
GEOS-Chem #800db9974 Bring PR #1998 on top of 14.4.0-alpha.3 (PR #1979)
HEMCO     #f807e1a Update HEMCO version number to 3.8.0 in preparation for release

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 21726783
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #2e516f8 GEOS-Chem submodule update: Merge PR #1979 (Updated NOAA GMD surface BCs)
GEOS-Chem #800db9974 Bring PR #1998 on top of 14.4.0-alpha.3 (PR #1979)
HEMCO     #f807e1a Update HEMCO version number to 3.8.0 in preparation for release

Number of execution tests: 6

Submitted as SLURM job: 21727499
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

@yantosca yantosca merged commit 66fb61a into dev/14.4.0 Feb 28, 2024
@yantosca yantosca deleted the feature/yaml-photo-nitrate-aerosol branch March 5, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attn: Chemistry WG Attention: Chemistry Working Group category: Feature Request New feature or request topic: Configuration Files Related to GEOS-Chem configuration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change names of YAML tags in the photolyze_nitrate_aerosol section
2 participants