Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.9.3+bugfix budget diagnostic #2002

Closed

Conversation

cdholmes
Copy link
Contributor

Name and Institution (Required)

Name: Christopher Holmes
Institution: Florida State University

Confirm you have reviewed the following documentation

Describe the update

With this update, the budget diagnostics include the troposphere and PBL mass tendencies associated with changes in the PBL height and tropopause height. The effect of changing tropopause height is now included in the "BudgetTransportTrop" diagnostic. The effect of changing PBL height is now included in the "BudgetMixingPBL" diagnostic.

A second update improves the way that the model level number corresponding to the PBL depth is determined. The meteorological input files provide the PBL height. The previous method computed the pressure at the PBL top using a globally constant scale height. The revised method determines the level from the local grid cell heights, which is more appropriate. As a result of this change the mixing increases up to 1 level near the poles and decreases up to 1 or 2 levels in the tropics.

Expected changes

Figures show changes in the PBL due to the improved calculation.

Change in PBL top level (MERRA-2 2015-07-01 18z)
image

Change in PBL thickness, hPa (MERRA-2 2015-07-01 18z)
image

Reference(s)

none

Related Github Issue(s)

The budget diagnostic bug was discussed by GCSC. I corresponded with Lizzie about the issue.

Budget diagnostics now include mass tendency due to changes in
* Tropopause height (TransportTrop budget)
* PBL height (MixingPBL budget)

The implementation could probably be improved
as it currently assumes that Mixing occurs every
dynamic time step.

Signed-off-by: Christopher Holmes <cdholmes@fsu.edu>
Use local scale height and level thickness to determine
PBL top level and pressure thickness.
The code previously used a fixed global value for scale height,
which is too large near poles and too small in tropics.
This update lowers the PBL top level in the tropics and
raises it near the poles.
The change is typically 1 model level or less.

Signed-off-by: Christopher Holmes <cdholmes@fsu.edu>
@lizziel lizziel self-requested a review October 19, 2023 21:14
@lizziel lizziel changed the base branch from main to dev/14.3.0 December 11, 2023 19:45
@lizziel
Copy link
Contributor

lizziel commented Dec 12, 2023

Hi @cdholmes, I am reviewing your updates and getting them into the recent version. However, it looks like there may be part of the update missing. Do you also have updates for subroutine Compute_Budget_Diagnostics? As is, it is not clear how the two new budget arrays are computed.

@lizziel
Copy link
Contributor

lizziel commented Dec 12, 2023

Would you be able break this up into two different submitted updates? They would be (1) change how PBL top level is computed, and (2) add improvements to the transport trop and mixing PBL budgets. The first will change GEOS-Chem benchmark results and the latter will not. I am getting a lot of merge conflicts because 12.9.3 is so old. I can work through those for the diagnostics update but prefer that you make the PBL top level definition change off of the most recent version to avoid introducing bugs.

@lizziel lizziel self-assigned this Dec 12, 2023
@lizziel lizziel changed the base branch from dev/14.3.0 to main December 18, 2023 16:04
@cdholmes
Copy link
Contributor Author

@lizziel, The two fixes are in separate commits within this PR, but I can split the two PRs if that is helpful.

My fix for the budget diagnostic introduces two new arrays (BudgetTransportTropHeight and BudgetMixingPBLHeight) that quantify mass changes due to the tropopause and PBL height. These arrays are added into BudgetTransportTrop and BudgetMixingPBL within main.F90 at the end of each dynamics time step. There's no change to Compute_Budget_Diagnostics. I have not checked if the same strategy will work in 14.2

@cdholmes
Copy link
Contributor Author

@lizziel. I'll close this PR as the content is now split into two PRs: #2078 and #2079.

@cdholmes cdholmes closed this Dec 19, 2023
yantosca added a commit that referenced this pull request Mar 20, 2024
This merge brings PR #2078 (Fix PBL level calculations, by @cdholmes)
into the GEOS-Chem 14.4.0 development stream.

This PR now uses local scale height and level thickness to determine
the PBL top level and pressure thickness.  Also see issue #2002 for
more information.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants