[PULL REQUEST] ObsPack Bug Fix, Update for Instantaneous Sampling #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are multiple proposed changes/fixes to obspack_mod.F90. 1) There was a bug in the Seconds_Since_1970 function where the time conversion factor for fractional minutes of the day was 3600s instead of what should actually be 1440s (applied here). This means that ObsPack has been using the incorrect time steps for computing averages for users up until this point. 2) In the ObsPack wiki http://wiki.seas.harvard.edu/geos-chem/index.php/ObsPack_diagnostic there was mention of defining a CT_sampling_strategy of "4", meaning instantaneous sampling. However, the current obspack_mod.F90 does not include an option for instantaneous sampling. Here I provide the changes that allow for ObsPack to do instantaneous sampling. - In the ObsPack_Read_Input function a CASE 4 is added for instantaneous sampling - In the ObsPack_Sample function cases are used for the sampling strategy, in which, CASE 4 finds the closest model time step to the observational time step samples at that time. This has been tested and does now sample instantaneously at the closest model time step, REGARDLESS of what the dynamic time steps are for a given simulation.
chfite
changed the title
chfite
changed the title
chfite
changed the title
|
Thanks Charley. We will probably be able to get this into the code soon (after 12.7.0 benchmarking clears). |
|
This update has now passed unit tests. It has now been added to dev/12.7.1, and will ship with the 12.7.1 version (soon after 12.7.0 passes benchmarking). |
yantosca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple proposed changes/fixes to obspack_mod.F90.
There was a bug in the Seconds_Since_1970 function where the time conversion factor for fractional minutes of the day was 3600s instead of what should actually be 1440s (applied here). This means that ObsPack has been using the incorrect time steps for computing averages for users up until this point.
In the ObsPack wiki http://wiki.seas.harvard.edu/geos-chem/index.php/ObsPack_diagnostic there was mention of defining a CT_sampling_strategy of "4", meaning instantaneous sampling. However, the current obspack_mod.F90 does not include an option for instantaneous sampling. Here I provide the changes that allow for ObsPack to do instantaneous sampling.
the observational time step samples at that time.
This has been tested and does now sample instantaneously at the closest model time step, REGARDLESS of what the dynamic time steps are for a given simulation.